Adding Azure integration protobuf messages and gRPC methods #48628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvbrock
added
the
no-changelog
Tener
approved these changes
Nov 8, 2024
ryanclark
reviewed
Nov 8, 2024
tigrato
reviewed
Nov 8, 2024
mvbrock
force-pushed
the
mvbrock/azure-integration-grpc
branch
from
ba0b726 to
fe10587
Compare
|
@tigrato I added a few more items to the proto spec:
|
mvbrock
force-pushed
the
mvbrock/azure-integration-grpc
branch
2 times, most recently
from
6c2c286 to
7d10b7c
Compare
Co-authored-by: Tiago Silva <[email protected]>
Co-authored-by: Tiago Silva <[email protected]>
Co-authored-by: Tiago Silva <[email protected]>
… and role name to role definitions
mvbrock
force-pushed
the
mvbrock/azure-integration-grpc
branch
from
7d10b7c to
61e626b
Compare
tigrato
reviewed
Nov 27, 2024
| string subscription_id = 2; | ||
| google.protobuf.Timestamp last_sync_time = 3; | ||
| string display_name = 4; | ||
| repeated string member_of = 5; |
There was a problem hiding this comment.
what's this member of? are they groups, policies?
There was a problem hiding this comment.
Groups and directories, per https://learn.microsoft.com/en-us/graph/api/resources/user?view=graph-rest-1.0#relationships
tigrato
approved these changes
Nov 28, 2024
Co-authored-by: Tiago Silva <[email protected]>
public-teleport-github-review-bot
bot
removed request for
r0mant,
kimlisa and
atburke
mvbrock
added a commit
that referenced
this pull request
Jan 31, 2025
* Adding Azure integration gRPC messages and RPC methods * Make derive * Update proto/accessgraph/v1alpha/azure.proto Co-authored-by: Tiago Silva <[email protected]> * Update proto/accessgraph/v1alpha/azure.proto Co-authored-by: Tiago Silva <[email protected]> * Update proto/accessgraph/v1alpha/azure.proto Co-authored-by: Tiago Silva <[email protected]> * PR feedback * More PR feedback and generating protobuf code * Make derive * Adding identities field to principals, condition to role assignments, and role name to role definitions * Rebase conflicts * Did not fully fetch from origin/master when rebasing * Removing azure config field and keeping poll_interval as-is * Correct from parent branch * Apply suggestions from code review Co-authored-by: Tiago Silva <[email protected]> * PR feedback * Adding doc comments to access graph proto * Adding object type to principals * Adding location to Azure virtual machines * Update proto/accessgraph/v1alpha/access_graph_service.proto Co-authored-by: Tiago Silva <[email protected]> * Moving Azure Discovery protobuf config to the Azure Discovery PR * Make grpc --------- Co-authored-by: Tiago Silva <[email protected]>
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of of https://github.com/gravitational/access-graph/issues/640 to provide visibility of Azure resource in the Access Graph, and originating from the Azure integration POC branch master...mvbrock/azure-integration-poc. This PR creates the protobuf messages and gRPC methods to transmit Azure resources from the Discovery service to the Access Graph, per https://github.com/gravitational/access-graph/issues/1312.