-
Notifications
You must be signed in to change notification settings - Fork 275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
typescript migration #223
Draft
acao
wants to merge
8
commits into
master
Choose a base branch
from
typescript-migration
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
typescript migration #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acao
force-pushed
the
typescript-migration
branch
4 times, most recently
from
August 6, 2023 21:28
c94d7df
to
7db5316
Compare
acao
commented
Aug 7, 2023
need to update b/c of #236 especially |
acao
force-pushed
the
typescript-migration
branch
from
January 14, 2025 08:33
c08fc3d
to
4f2a7c8
Compare
moving this back to draft state, as the missing data in the new source is causing big issues with tests/etc for reference, this rewrite happened when we were using swapi.dev, but now that it's gone, we're using swapi.tech which is missing a lot of data on index routes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
redo of #191 , with a
graphql
upgrade as welltype: module
so that we're using the latest and greatest in module resolution/etcvitest.config.ts
contains an alias to use cjs graphql becausegraphql-relay
doesn't publish a module bundle yet (otherwise tests have realm error)eslint
setup to typescript eslint recommended for simplicitycache/data.json
both in netlify and github actions for faster CIpackage-lock.json
Update: lost a ton of data when switching to swapi.tech
I will pull in the raw datasource in this PR and fix the issue for once and for all