-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch NPM package to support only ESM #3552
Conversation
✅ Deploy Preview for compassionate-pike-271cb3 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Hi @IvanGoncharov, I'm @github-actions bot happy to help you with this PR 👋 Supported commandsPlease post this commands in separate comments and only one per comment:
|
@IvanGoncharov what about #3361 ? |
@saihaj As we agreed, let's try with full ESM first, and if the community strongly asks for CJS we can go the #3361 approach with dual packages. |
As disscussed during graphql-js-wg: https://github.com/graphql/graphql-js-wg/blob/main/agendas/2022-03-30.md
I mean the work was already done there and we just need to that |
@IvanGoncharov we have tests in that PR |
ok but we can just push a commit on initial work done there and wait for @graphql/graphql-js-reviewers team for review |
As disscussed during graphql-js-wg:
https://github.com/graphql/graphql-js-wg/blob/main/agendas/2022-03-30.md