feat(opentelemetry): add sampling rate #968

EmrysMyrddin · 2025-03-27T23:25:30Z

Related to GW-91

Copilot

Pull Request Overview

This PR fixes span parenting issues and improves batching support for OpenTelemetry instrumentation across multiple packages and end-to-end tests. Key changes include:

Removing the setExecutionRequest callback in favor of directly mutating executionRequest.extensions.
Refactoring executor wrapping and instrumentation handling in the runtime.
Updating test expectations and configuration parameters for both OpenTelemetry and Cloudflare Workers integrations.

Reviewed Changes

Copilot reviewed 28 out of 34 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
packages/plugins/hmac-upstream-signature/src/index.ts	Removed setExecutionRequest usage and updated signature assignment logic.
packages/fusion-runtime/src/utils.ts	Refactored executor wrapping and integrated instrumentation handling.
packages/fusion-runtime/src/unifiedGraphManager.ts	Updated instrumentation payload type to include subgraphName.
e2e/opentelemetry/opentelemetry.e2e.ts	Modified test expectations and adjusted timeout and error handling logic.
e2e/opentelemetry/gateway.config.ts	Added diagnostic level and batching configuration for exporters.
e2e/cloudflare-workers/src/index.ts	Changed runtime initialization to lazy caching for Cloudflare Workers.
e2e/cloudflare-workers/cloudflare-workers.e2e.ts	Updated expectations and formatting of numeric literals in tests.
DEPS_RESOLUTIONS_NOTES.md, .changeset/*	Various dependency updates and changelog documentation for breaking changes.

Files not reviewed (6)

.yarn/patches/@opentelemetry-exporter-trace-otlp-http-npm-0.200.0-80a44c64cd.patch: Language not supported
.yarn/patches/@opentelemetry-otlp-exporter-base-npm-0.200.0-6fb25211c7.patch: Language not supported
.yarn/patches/@opentelemetry-otlp-exporter-base-npm-0.56.0-ba3dc5f5c5.patch: Language not supported
.yarn/patches/@opentelemetry-resources-npm-1.29.0-112f89f0c5.patch: Language not supported
.yarn/patches/@opentelemetry-resources-npm-2.0.0-f20376a5f9.patch: Language not supported
package.json: Language not supported

Copilot · 2025-03-27T23:26:00Z

e2e/opentelemetry/opentelemetry.e2e.ts

      ): Promise<void> {
        const url = `http://0.0.0.0:${jaeger.additionalPorts[16686]}/api/traces?service=${service}`;

        let res!: JaegerTracesApiResponse;
        let err: any;
-        const signal = AbortSignal.timeout(15_000);
+        const timeout = AbortSignal.timeout(15_00);


The numeric literal '15_00' may be a typo: if a 15-second timeout was intended, it should likely be '15_000' to avoid unintended shorter timeouts.

Suggested change

const timeout = AbortSignal.timeout(15_00);

const timeout = AbortSignal.timeout(15_000);

theguild-bot · 2025-03-27T23:28:18Z

🚀 Snapshot Release (`alpha`)

The latest changes of this PR are available as alpha on npm (based on the declared changesets):

Package	Version	Info
`@graphql-mesh/fusion-runtime`	`0.11.11-alpha-e50027355a2e37471e153a27787d6392630d1724`	npm ↗︎ unpkg ↗︎
`@graphql-hive/gateway`	`1.13.7-alpha-e50027355a2e37471e153a27787d6392630d1724`	npm ↗︎ unpkg ↗︎
`@graphql-hive/nestjs`	`1.0.11-alpha-e50027355a2e37471e153a27787d6392630d1724`	npm ↗︎ unpkg ↗︎
`@graphql-hive/plugin-aws-sigv4`	`1.0.8-alpha-e50027355a2e37471e153a27787d6392630d1724`	npm ↗︎ unpkg ↗︎
`@graphql-mesh/plugin-jwt-auth`	`1.5.4-alpha-e50027355a2e37471e153a27787d6392630d1724`	npm ↗︎ unpkg ↗︎
`@graphql-mesh/plugin-opentelemetry`	`2.0.0-alpha-e50027355a2e37471e153a27787d6392630d1724`	npm ↗︎ unpkg ↗︎
`@graphql-mesh/plugin-prometheus`	`1.3.43-alpha-e50027355a2e37471e153a27787d6392630d1724`	npm ↗︎ unpkg ↗︎
`@graphql-hive/gateway-runtime`	`1.8.1-alpha-e50027355a2e37471e153a27787d6392630d1724`	npm ↗︎ unpkg ↗︎

theguild-bot · 2025-03-27T23:31:19Z

🚀 Snapshot Release (Binary for `Linux-X64`)

The latest changes of this PR are available for download (based on the declared changesets).

theguild-bot · 2025-03-27T23:31:29Z

🚀 Snapshot Release (Binary for `macOS-ARM64`)

The latest changes of this PR are available for download (based on the declared changesets).

theguild-bot · 2025-03-27T23:31:55Z

🚀 Snapshot Release (Binary for `Linux-ARM64`)

The latest changes of this PR are available for download (based on the declared changesets).

theguild-bot · 2025-03-27T23:32:33Z

🚀 Snapshot Release (Node Docker Image)

The latest changes of this PR are available as image on GitHub Container Registry (based on the declared changesets):

ghcr.io/graphql-hive/gateway:1.13.7-alpha-e50027355a2e37471e153a27787d6392630d1724

theguild-bot · 2025-03-27T23:32:45Z

🚀 Snapshot Release (Bun Docker Image)

The latest changes of this PR are available as image on GitHub Container Registry (based on the declared changesets):

ghcr.io/graphql-hive/gateway:1.13.7-alpha-e50027355a2e37471e153a27787d6392630d1724-bun

theguild-bot · 2025-03-27T23:33:11Z

🚀 Snapshot Release (Binary for `macOS-X64`)

The latest changes of this PR are available for download (based on the declared changesets).

theguild-bot · 2025-03-27T23:36:17Z

🚀 Snapshot Release (Binary for `Windows-X64`)

The latest changes of this PR are available for download (based on the declared changesets).

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

Copilot AI review requested due to automatic review settings March 27, 2025 23:25

EmrysMyrddin changed the base branch from main to v2 March 27, 2025 23:25

EmrysMyrddin changed the title ~~feat(opentelemetry): correct span parenting + fix batching support~~ feat(opentelemetry): add sampling rate Mar 27, 2025

Copilot AI reviewed Mar 27, 2025

View reviewed changes

dotansimha approved these changes Apr 6, 2025

View reviewed changes

EmrysMyrddin requested a review from ardatan April 8, 2025 18:35

enisdenjo force-pushed the v2 branch 2 times, most recently from e101965 to f246857 Compare April 9, 2025 13:38

EmrysMyrddin force-pushed the feat/otel/sampling-strategy branch from 74dcf64 to bf56c1c Compare April 10, 2025 18:40

enisdenjo force-pushed the v2 branch from 7ac617e to 3563e2b Compare April 11, 2025 17:50

EmrysMyrddin force-pushed the feat/otel/sampling-strategy branch from bf56c1c to 9a1bf25 Compare April 11, 2025 19:03

EmrysMyrddin force-pushed the v2 branch from 3563e2b to 2881d4f Compare April 12, 2025 11:11

EmrysMyrddin force-pushed the feat/otel/sampling-strategy branch from 9a1bf25 to 4c57231 Compare April 12, 2025 11:13

ardatan approved these changes Apr 13, 2025

View reviewed changes

enisdenjo force-pushed the v2 branch 3 times, most recently from 5879f2b to 0bc8a1c Compare April 17, 2025 17:50

EmrysMyrddin and others added 5 commits April 18, 2025 20:12

feat(opentelemetry): add sampling rate

e7ac075

changeset

5dcc144

chore(dependencies): updated changesets for modified dependencies

3b2a444

chore(dependencies): updated changesets for modified dependencies

2bc1bed

fix tests

3061c0f

remove unused imports

e500273

EmrysMyrddin force-pushed the feat/otel/sampling-strategy branch from 4c57231 to e500273 Compare April 18, 2025 18:12

EmrysMyrddin merged commit 1a58317 into v2 Apr 18, 2025
61 checks passed

EmrysMyrddin deleted the feat/otel/sampling-strategy branch April 18, 2025 18:47

enisdenjo pushed a commit that referenced this pull request Apr 21, 2025

feat(opentelemetry): add sampling rate (#968)

4c13fcc

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

enisdenjo pushed a commit that referenced this pull request May 12, 2025

feat(opentelemetry): add sampling rate (#968)

e477285

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

enisdenjo pushed a commit that referenced this pull request May 20, 2025

feat(opentelemetry): add sampling rate (#968)

80e5bec

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

enisdenjo pushed a commit that referenced this pull request May 22, 2025

feat(opentelemetry): add sampling rate (#968)

14b38b2

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

enisdenjo pushed a commit that referenced this pull request Jun 5, 2025

feat(opentelemetry): add sampling rate (#968)

7decf1d

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(opentelemetry): add sampling rate #968

feat(opentelemetry): add sampling rate #968

Uh oh!

EmrysMyrddin commented Mar 27, 2025 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Mar 27, 2025

Uh oh!

theguild-bot commented Mar 27, 2025 •

edited

Loading

Uh oh!

theguild-bot commented Mar 27, 2025 •

edited

Loading

Uh oh!

theguild-bot commented Mar 27, 2025 •

edited

Loading

Uh oh!

theguild-bot commented Mar 27, 2025 •

edited

Loading

Uh oh!

theguild-bot commented Mar 27, 2025 •

edited

Loading

Uh oh!

theguild-bot commented Mar 27, 2025 •

edited

Loading

Uh oh!

theguild-bot commented Mar 27, 2025 •

edited

Loading

Uh oh!

theguild-bot commented Mar 27, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

	const timeout = AbortSignal.timeout(15_00);
	const timeout = AbortSignal.timeout(15_000);

feat(opentelemetry): add sampling rate #968

feat(opentelemetry): add sampling rate #968

Uh oh!

Conversation

EmrysMyrddin commented Mar 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Mar 27, 2025

Choose a reason for hiding this comment

Uh oh!

theguild-bot commented Mar 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🚀 Snapshot Release (alpha)

Uh oh!

theguild-bot commented Mar 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🚀 Snapshot Release (Binary for Linux-X64)

Uh oh!

theguild-bot commented Mar 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🚀 Snapshot Release (Binary for macOS-ARM64)

Uh oh!

theguild-bot commented Mar 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🚀 Snapshot Release (Binary for Linux-ARM64)

Uh oh!

theguild-bot commented Mar 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🚀 Snapshot Release (Node Docker Image)

Uh oh!

theguild-bot commented Mar 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🚀 Snapshot Release (Bun Docker Image)

Uh oh!

theguild-bot commented Mar 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🚀 Snapshot Release (Binary for macOS-X64)

Uh oh!

theguild-bot commented Mar 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🚀 Snapshot Release (Binary for Windows-X64)

Uh oh!

Uh oh!

Uh oh!

EmrysMyrddin commented Mar 27, 2025 •

edited

Loading

theguild-bot commented Mar 27, 2025 •

edited

Loading

🚀 Snapshot Release (`alpha`)

theguild-bot commented Mar 27, 2025 •

edited

Loading

🚀 Snapshot Release (Binary for `Linux-X64`)

theguild-bot commented Mar 27, 2025 •

edited

Loading

🚀 Snapshot Release (Binary for `macOS-ARM64`)

theguild-bot commented Mar 27, 2025 •

edited

Loading

🚀 Snapshot Release (Binary for `Linux-ARM64`)

theguild-bot commented Mar 27, 2025 •

edited

Loading

theguild-bot commented Mar 27, 2025 •

edited

Loading

theguild-bot commented Mar 27, 2025 •

edited

Loading

🚀 Snapshot Release (Binary for `macOS-X64`)

theguild-bot commented Mar 27, 2025 •

edited

Loading

🚀 Snapshot Release (Binary for `Windows-X64`)