Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(federation): shared mutation field should not be batched #387

Merged
merged 1 commit into from
Dec 31, 2024
Merged

fix(federation): shared mutation field should not be batched #387

merged 1 commit into from
Dec 31, 2024

Conversation

ardatan
Copy link
Member

@ardatan ardatan commented Dec 27, 2024

In case of shared root field on Mutation, it was batched incorrectly across subgraphs. But instead only one mutation should be called as mutations should not be parallel

@theguild-bot
Copy link
Collaborator

theguild-bot commented Dec 27, 2024 •
edited
Loading

🚀 Snapshot Release (alpha)

The latest changes of this PR are available as alpha on npm (based on the declared changesets):

Package Version Info
@graphql-tools/batch-delegate 9.0.26-alpha-4b17cc18283b53bb01a7f4af8969cafb56d38c05 npm ↗︎ unpkg ↗︎
@graphql-tools/federation 3.0.6-alpha-4b17cc18283b53bb01a7f4af8969cafb56d38c05 npm ↗︎ unpkg ↗︎
@graphql-mesh/fusion-runtime 0.10.26-alpha-4b17cc18283b53bb01a7f4af8969cafb56d38c05 npm ↗︎ unpkg ↗︎
@graphql-hive/gateway 1.7.5-alpha-4b17cc18283b53bb01a7f4af8969cafb56d38c05 npm ↗︎ unpkg ↗︎
@graphql-mesh/plugin-opentelemetry 1.3.33-alpha-4b17cc18283b53bb01a7f4af8969cafb56d38c05 npm ↗︎ unpkg ↗︎
@graphql-mesh/plugin-prometheus 1.3.21-alpha-4b17cc18283b53bb01a7f4af8969cafb56d38c05 npm ↗︎ unpkg ↗︎
@graphql-hive/gateway-runtime 1.4.5-alpha-4b17cc18283b53bb01a7f4af8969cafb56d38c05 npm ↗︎ unpkg ↗︎
@graphql-tools/stitch 9.4.12-alpha-4b17cc18283b53bb01a7f4af8969cafb56d38c05 npm ↗︎ unpkg ↗︎

@ardatan ardatan force-pushed the no-batch-mutation branch 2 times, most recently from d8bb597 to 0659f04 Compare December 27, 2024 14:04
@theguild-bot
Copy link
Collaborator

theguild-bot commented Dec 27, 2024 •
edited
Loading

🚀 Snapshot Release (Binary for macOS-ARM64)

The latest changes of this PR are available for download (based on the declared changesets).

Download

@theguild-bot
Copy link
Collaborator

theguild-bot commented Dec 27, 2024 •
edited
Loading

🚀 Snapshot Release (Binary for Linux-X64)

The latest changes of this PR are available for download (based on the declared changesets).

Download

@theguild-bot
Copy link
Collaborator

theguild-bot commented Dec 27, 2024 •
edited
Loading

🚀 Snapshot Release (Bun Docker Image)

The latest changes of this PR are available as image on GitHub Container Registry (based on the declared changesets):

ghcr.io/graphql-hive/gateway:1.7.5-alpha-4b17cc18283b53bb01a7f4af8969cafb56d38c05-bun

@theguild-bot
Copy link
Collaborator

theguild-bot commented Dec 27, 2024 •
edited
Loading

🚀 Snapshot Release (Node Docker Image)

The latest changes of this PR are available as image on GitHub Container Registry (based on the declared changesets):

ghcr.io/graphql-hive/gateway:1.7.5-alpha-4b17cc18283b53bb01a7f4af8969cafb56d38c05

@theguild-bot
Copy link
Collaborator

theguild-bot commented Dec 27, 2024 •
edited
Loading

🚀 Snapshot Release (Binary for macOS-X64)

The latest changes of this PR are available for download (based on the declared changesets).

Download

@theguild-bot
Copy link
Collaborator

theguild-bot commented Dec 27, 2024 •
edited
Loading

🚀 Snapshot Release (Binary for Windows-X64)

The latest changes of this PR are available for download (based on the declared changesets).

Download

Urigo
Urigo approved these changes Dec 31, 2024
View reviewed changes
Copy link

@Urigo Urigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @ardatan
Is this a case that could also fit into the audit?

@ardatan
Copy link
Member Author

ardatan commented Dec 31, 2024

@Urigo It is actually an implementation detail(causing extra operation) not a compatibility issue.

@ardatan ardatan merged commit 3571399 into main Dec 31, 2024
36 checks passed
@ardatan ardatan deleted the no-batch-mutation branch December 31, 2024 14:22
@theguild-bot theguild-bot mentioned this pull request Dec 31, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Urigo Urigo Urigo approved these changes

@dotansimha dotansimha Awaiting requested review from dotansimha

@EmrysMyrddin EmrysMyrddin Awaiting requested review from EmrysMyrddin

@enisdenjo enisdenjo Awaiting requested review from enisdenjo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ardatan @theguild-bot @Urigo