Skip to content

Fixes on Demand Control #1027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fixes on Demand Control #1027

wants to merge 2 commits into from

Conversation

ardatan
Copy link
Member

@ardatan ardatan commented Apr 9, 2025

Ref GW-300

  • If metadata is included the result with includeExtensionMetadata, cost.esTimated should always be added to the result extensions even if no cost is calculated. So the estimated cost will be 0 in this case. For example { __typename } never hits any subgraph or QP, then it should be 0.
  • When multiple root fields are requested from a subgraph(batched execution), and the cost error is thrown as sync then this causes a sync error in DataLoader, and this causes a cryptic error which is masked unexpectedly. In the batching executor, the sync errors are handled and returned in an array that has the same size of the batched requests.

@Copilot Copilot AI review requested due to automatic review settings April 9, 2025 10:35
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

@theguild-bot
Copy link
Collaborator

theguild-bot commented Apr 9, 2025

🚀 Snapshot Release (alpha)

The latest changes of this PR are available as alpha on npm (based on the declared changesets):

Package Version Info
@graphql-tools/batch-delegate 9.0.36-alpha-3fb8d587b41638f428d90309c8cf2dcd31edc8e3 npm ↗︎ unpkg ↗︎
@graphql-tools/batch-execute 9.0.16-alpha-3fb8d587b41638f428d90309c8cf2dcd31edc8e3 npm ↗︎ unpkg ↗︎
@graphql-tools/delegate 10.2.18-alpha-3fb8d587b41638f428d90309c8cf2dcd31edc8e3 npm ↗︎ unpkg ↗︎
@graphql-tools/federation 3.2.2-alpha-3fb8d587b41638f428d90309c8cf2dcd31edc8e3 npm ↗︎ unpkg ↗︎
@graphql-mesh/fusion-runtime 0.11.11-alpha-3fb8d587b41638f428d90309c8cf2dcd31edc8e3 npm ↗︎ unpkg ↗︎
@graphql-hive/gateway 1.13.7-alpha-3fb8d587b41638f428d90309c8cf2dcd31edc8e3 npm ↗︎ unpkg ↗︎
@graphql-hive/nestjs 1.0.11-alpha-3fb8d587b41638f428d90309c8cf2dcd31edc8e3 npm ↗︎ unpkg ↗︎
@graphql-hive/plugin-aws-sigv4 1.0.8-alpha-3fb8d587b41638f428d90309c8cf2dcd31edc8e3 npm ↗︎ unpkg ↗︎
@graphql-mesh/plugin-opentelemetry 1.3.55-alpha-3fb8d587b41638f428d90309c8cf2dcd31edc8e3 npm ↗︎ unpkg ↗︎
@graphql-mesh/plugin-prometheus 1.3.43-alpha-3fb8d587b41638f428d90309c8cf2dcd31edc8e3 npm ↗︎ unpkg ↗︎
@graphql-hive/gateway-runtime 1.8.1-alpha-3fb8d587b41638f428d90309c8cf2dcd31edc8e3 npm ↗︎ unpkg ↗︎
@graphql-tools/stitch 9.4.23-alpha-3fb8d587b41638f428d90309c8cf2dcd31edc8e3 npm ↗︎ unpkg ↗︎
@graphql-tools/stitching-directives 3.1.33-alpha-3fb8d587b41638f428d90309c8cf2dcd31edc8e3 npm ↗︎ unpkg ↗︎
@graphql-tools/wrap 10.0.36-alpha-3fb8d587b41638f428d90309c8cf2dcd31edc8e3 npm ↗︎ unpkg ↗︎

@theguild-bot
Copy link
Collaborator

theguild-bot commented Apr 9, 2025

🚀 Snapshot Release (Binary for Linux-X64)

The latest changes of this PR are available for download (based on the declared changesets).

Download

@theguild-bot
Copy link
Collaborator

theguild-bot commented Apr 9, 2025

🚀 Snapshot Release (Binary for Linux-ARM64)

The latest changes of this PR are available for download (based on the declared changesets).

Download

@theguild-bot
Copy link
Collaborator

theguild-bot commented Apr 9, 2025

🚀 Snapshot Release (Binary for macOS-ARM64)

The latest changes of this PR are available for download (based on the declared changesets).

Download

@theguild-bot
Copy link
Collaborator

theguild-bot commented Apr 9, 2025

🚀 Snapshot Release (Node Docker Image)

The latest changes of this PR are available as image on GitHub Container Registry (based on the declared changesets):

ghcr.io/graphql-hive/gateway:1.13.7-alpha-3fb8d587b41638f428d90309c8cf2dcd31edc8e3

@theguild-bot
Copy link
Collaborator

theguild-bot commented Apr 9, 2025

🚀 Snapshot Release (Bun Docker Image)

The latest changes of this PR are available as image on GitHub Container Registry (based on the declared changesets):

ghcr.io/graphql-hive/gateway:1.13.7-alpha-3fb8d587b41638f428d90309c8cf2dcd31edc8e3-bun

@theguild-bot
Copy link
Collaborator

theguild-bot commented Apr 9, 2025

🚀 Snapshot Release (Binary for macOS-X64)

The latest changes of this PR are available for download (based on the declared changesets).

Download

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

@ardatan ardatan force-pushed the fixes-demand-control branch from f8c57ab to 3be8c97 Compare April 9, 2025 10:43
@theguild-bot
Copy link
Collaborator

theguild-bot commented Apr 9, 2025

🚀 Snapshot Release (Binary for Windows-X64)

The latest changes of this PR are available for download (based on the declared changesets).

Download

@ardatan ardatan enabled auto-merge (squash) April 9, 2025 11:53
@ardatan ardatan force-pushed the fixes-demand-control branch from 3be8c97 to f87a0b3 Compare April 9, 2025 14:52
@ardatan ardatan disabled auto-merge April 9, 2025 14:52
@ardatan ardatan enabled auto-merge (squash) April 10, 2025 10:02
@ardatan ardatan force-pushed the fixes-demand-control branch from 00a4131 to 80c5306 Compare April 10, 2025 10:02
@ardatan ardatan force-pushed the fixes-demand-control branch from 80c5306 to 3fb8d58 Compare April 16, 2025 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants