Replace charged language "whitelist/blacklist" #1570
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 24c862d.
Current coverage is 56.25%@@ master #1570 diff @@
==========================================
Files 52 52
Lines 5781 5781
Methods 0 0
Messages 0 0
Branches 1111 1111
==========================================
Hits 3252 3252
Misses 2328 2328
Partials 201 201
|
…d_metrics in web components
|
I haven't had a chance to test, but I think that this is all of the edits that I need to make. @graphite-project/committers please have a look. |
|
@gwaldo can you rebase from master? I can help resolve any issues with the unit tests after that, unless you wish to do them yourself. |
|
@gwaldo Got time to rebase? |
|
@gwaldo Do you have time to continue work on this? If not I can pick it up from you, just let me know. |
|
I haven't had time/energy to work on this, so yes, @obfuscurity (per our chat), I would be perfectly happy if you would be able to finish it. |
|
Closing in favor of #1700. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing #1569
Related to graphite-project/carbon#567 / graphite-project/carbon#568
EDIT: This isn't tested, but is ready for review.