fix(demos): Fix Splunk integration in Corelight notebook #720
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous implementation had broken JSON parsing in splunkToPandas function causing data retrieval failures. * Fix splunkToPandas to use JSONResultsReader with proper output_mode * Fix regex escape sequence warnings in helper functions * Add proper error handling for pagination * Clean up notebook structure This ensures the demo notebook works correctly with current Splunk SDK and maintains clean example code.
Add secure credential management to the Corelight demo notebook while preserving the Splunk integration fixes. * Add python-dotenv dependency for environment variable support * Implement hierarchical configuration: manual > env vars > .env file * Add comprehensive documentation for all configuration options * Provide clear success/failure feedback for Graphistry registration * Maintain backward compatibility with manual configuration * Fix regex escape sequence warnings in helper functions * Preserve all existing Splunk integration fixes This combines secure credential management with the working Splunk functionality, providing users with a complete and secure demo experience.
…ebook Extend environment variable support to include Splunk configuration, providing secure credential management for both services. * Add Splunk environment variable support with hierarchical configuration * Update documentation to show both Graphistry and Splunk .env settings * Add connection feedback for Splunk with clear success/failure messages * Maintain backward compatibility with manual configuration * Support all Splunk connection parameters: host, scheme, port, username, password This completes the secure credential management implementation by supporting both Graphistry and Splunk credentials through environment variables, making the demo easier and safer to use.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous implementation had broken JSON parsing in splunkToPandas function causing data retrieval failures.
This ensures the demo notebook works correctly with current Splunk SDK and maintains clean example code.