Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding a callout to graphile config docs re merging exists-but-undefined options #2290

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jcgsville
Copy link
Contributor

Description

Addresses #2286

When reading through the middleware code, I also noticed one variable was somewhat confusingly named. I recommend changing it to activityName. Happy to do it in another PR or not do it if you'd rather not mix docs with this nitpick code change

Note that running yarn prettier 'utils/website/graphile-config/preset.md' --write with the proseWrap: "preserve", commented out also seemed to adjust a few newlines.

Performance impact

Just docs

Security impact

None

Checklist

  • My code matches the project's code style and yarn lint:fix passes.

Copy link

changeset-bot bot commented Dec 27, 2024

⚠️ No Changeset found

Latest commit: c1e65a7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🌳 Triage
Development

Successfully merging this pull request may close these issues.

1 participant