Skip to content

feat!: Require node >= 22 for jsoo 6 #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 30, 2025

Conversation

spotandjake
Copy link
Member

@spotandjake spotandjake commented Mar 25, 2025

This enables ocaml 5 with esy.

This adds the setup-node script to opam workflow as we need node 22 when running the tests see here

Based of: #112

Closes: #88

Copy link
Member

@ospencer ospencer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The suggested changes might result in a change to the lock file. Also, this is breaking because it requires node 22 now.

@spotandjake spotandjake changed the title feat: Allow ocaml 5 with esy feat!: Allow ocaml 5 with esy Mar 28, 2025
@spotandjake spotandjake force-pushed the spotandjake-ocaml-5 branch from fcf1c2d to 5a7d04e Compare March 28, 2025 19:58
@spotandjake spotandjake changed the title feat!: Allow ocaml 5 with esy feat!: Require node >= 22 for jsoo 6 Mar 28, 2025
@ospencer ospencer merged commit 01d2926 into grain-lang:main Mar 30, 2025
13 checks passed
spotandjake added a commit to spotandjake/binaryen.ml that referenced this pull request May 17, 2025
This supersedes grain-lang#211 in switching to jsoo 6, the main difference is we need to be using a later version of node on our opam workflows, similar to the changes required here grain-lang/libbinaryen#114
ospencer pushed a commit to grain-lang/binaryen.ml that referenced this pull request May 18, 2025
* chore!: Require jsoo >= 6.0

This supersedes #211 in switching to jsoo 6, the main difference is we need to be using a later version of node on our opam workflows, similar to the changes required here grain-lang/libbinaryen#114

* chore: Remove jsoo changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Properly support Ocaml 5
2 participants