Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make substatus data available #393

Merged
merged 3 commits into from
Jan 16, 2025
Merged

Make substatus data available #393

merged 3 commits into from
Jan 16, 2025

Conversation

aboks
Copy link
Contributor

@aboks aboks commented Dec 18, 2024

Makes the substatus field available. This allows distinguishing between new, ongoing and regressed issues.

@aboks aboks requested a review from a team as a code owner December 18, 2024 10:56
@aboks aboks requested review from bossinc, aangelisc, adamyeats and alyssabull and removed request for a team December 18, 2024 10:56
@CLAassistant
Copy link

CLAassistant commented Dec 18, 2024

CLA assistant check
All committers have signed the CLA.

@bossinc
Copy link
Contributor

bossinc commented Jan 13, 2025

Looks good! Thank you for the PR

@bossinc bossinc enabled auto-merge (squash) January 13, 2025 16:40
Copy link
Contributor

@adamyeats adamyeats left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aboks Thanks for the contribution! There's a minor CI failure here:


26/66 ./pkg/sentry/issues.go 17.59ms X
/drone/src/pkg/sentry/issues.go:17:2 - Unknown word (Substatus)
/drone/src/pkg/sentry/issues.go:17:31 - Unknown word (substatus)

Could you add the words Substatus and substatus to the cspell.config.json and push? I would do this for you, but as this was submitted from a fork, I don't have commit rights on this PR.

auto-merge was automatically disabled January 14, 2025 13:47

Head branch was pushed to by a user without write access

@aboks
Copy link
Contributor Author

aboks commented Jan 14, 2025

Sure, it should be in the word list now.

@adamyeats
Copy link
Contributor

@aboks Thank you! There also seems to be a failing test:

        	Error Trace:	/drone/src/pkg/handlers/handlers_test.go:29
        	Error:      	Not equal: 
        	            	expected: 32
        	            	actual  : 33
        	Test:       	TestSentryDatasource_Issues/valid_org_slug_should_not_throw_error
--- FAIL: TestSentryDatasource_Issues (0.00s)
    --- FAIL: TestSentryDatasource_Issues/valid_org_slug_should_not_throw_error (0.00s)

@aboks
Copy link
Contributor Author

aboks commented Jan 15, 2025

@adamyeats I don't really see how my change could cause that test to fail, or where that test failure is visible in the workflow output. I've rebased my branch on main, maybe that helps? Otherwise I'd happily give you commit permissions to my fork if that helps to resolve things.

@adamyeats
Copy link
Contributor

@aboks The failing assertion tests the number of fields in a response given a valid organisation slug. You're adding an extra field to the response, so this will make the test fail. Simply incrementing the number by 1 in the assertion should fix the test.

aboks and others added 3 commits January 16, 2025 01:55
Makes the `substatus` field available. This allows distinguishing between new, ongoing and regressed issues.
@adamyeats adamyeats merged commit 96aafb0 into grafana:main Jan 16, 2025
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants