-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make substatus data available #393
Conversation
Looks good! Thank you for the PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aboks Thanks for the contribution! There's a minor CI failure here:
26/66 ./pkg/sentry/issues.go 17.59ms X
/drone/src/pkg/sentry/issues.go:17:2 - Unknown word (Substatus)
/drone/src/pkg/sentry/issues.go:17:31 - Unknown word (substatus)
Could you add the words Substatus
and substatus
to the cspell.config.json
and push? I would do this for you, but as this was submitted from a fork, I don't have commit rights on this PR.
Head branch was pushed to by a user without write access
Sure, it should be in the word list now. |
@aboks Thank you! There also seems to be a failing test:
|
@adamyeats I don't really see how my change could cause that test to fail, or where that test failure is visible in the workflow output. I've rebased my branch on main, maybe that helps? Otherwise I'd happily give you commit permissions to my fork if that helps to resolve things. |
@aboks The failing assertion tests the number of fields in a response given a valid organisation slug. You're adding an extra field to the response, so this will make the test fail. Simply incrementing the number by 1 in the assertion should fix the test. |
Makes the `substatus` field available. This allows distinguishing between new, ongoing and regressed issues.
Makes the
substatus
field available. This allows distinguishing between new, ongoing and regressed issues.