feat: (sceneQueryRunner) - allow manual timerange override, pass props to useQueryRunner #1098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s to useQueryRunner
torkelo
reviewed
Apr 16, 2025
| @@ -75,6 +75,8 @@ export interface QueryRunnerState extends SceneObjectState { | |||
| dataLayerFilter?: DataLayerFilter; | |||
| // Private runtime state | |||
| _hasFetchedData?: boolean; | |||
| // Optional timeRange to use instead of sceneGraph timeRange | |||
| timeRange?: SceneTimeRangeLike; | |||
There was a problem hiding this comment.
not sure this makes sense, all scene objects can already have local time range via $timeRange
Comment on lines
+14
to
+16
| // Optional timeRange to use instead of sceneGraph timeRange | ||
| runQueriesMode?: 'auto' | 'manual'; | ||
| timeRange?: SceneTimeRangeLike; |
There was a problem hiding this comment.
- the comment is on the wrong prop
- Feels like passing a SceneTimeRangeLike is wrong here vs a plain TimeRange prop. Also would need to add diffing so when prop changes query is executed (when runQueriesMode is auto)
- VizPanel uses sceneGraph.getTimeRange as well to change time range, for zoom in on graphs so that will not work with this approach.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
POC💡 original thread