Skip to content

AdHocVariables: Allow custom value to be first #1066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

AdHocVariables: Allow custom value to be first #1066

wants to merge 3 commits into from

Conversation

gtk-grafana
Copy link
Contributor

@gtk-grafana gtk-grafana commented Feb 27, 2025 •
edited by scenes-repo-bot-access-token bot
Loading

Allows pushing the custom variable to the top of the list in ad hoc variables.

Notes for reviewer:
The type for allowCustomVariable: allowCustomValue?: boolean | 'first'; is admittedly not very ergonomic, but I wasn't sure if we wanted to add an additional state property for this.

Fixes: #1065.

📦 Published PR as canary version: 6.2.0--canary.1066.13575913588.0

✨ Test out this PR locally via:

npm install @grafana/[email protected]
npm install @grafana/[email protected]
# or 
yarn add @grafana/[email protected]
yarn add @grafana/[email protected]

@gtk-grafana gtk-grafana marked this pull request as ready for review February 27, 2025 21:25
@gtk-grafana gtk-grafana requested review from dprokop, torkelo and ashharrison90 and removed request for torkelo February 27, 2025 21:25
@gtk-grafana gtk-grafana self-assigned this Feb 27, 2025
@gtk-grafana gtk-grafana added area/variables Issues related to variables system in scenes release Create a release when this pr is merged minor Increment the minor version when merged and removed release Create a release when this pr is merged labels Feb 27, 2025
@gtk-grafana gtk-grafana mentioned this pull request Feb 27, 2025
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dprokop dprokop Awaiting requested review from dprokop

@ashharrison90 ashharrison90 Awaiting requested review from ashharrison90

@torkelo torkelo Awaiting requested review from torkelo

At least 1 approving review is required to merge this pull request.

Assignees

@gtk-grafana gtk-grafana

Labels
area/variables Issues related to variables system in scenes minor Increment the minor version when merged release Create a release when this pr is merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AdHocFilters: Allow custom value to be first
1 participant
@gtk-grafana