Add async support to LabelsWrapper #118
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add target for `net8.0`.
Update to Python 3.12.
Add new overloads to `LabelsWrapper` to support `async` and passing through state to avoid allocating closures.
Update the application in the integration tests to .NET 8 and use more modern C# features.
- Make field `readonly`. - Make private class `sealed`.
`Task.Yield()` is slow, so only do 1,000 iterations.
martincostello
added a commit
to martincostello/costellobot
that referenced
this pull request
Sep 19, 2025
Consume changes from grafana/pyroscope-dotnet#118.
Add `net6.0` back to the Rideshare example.
Use A-Z order.
Handle `TargetFrameworks` instead of `TargetFramework`.
It breaks the integration tests, and isn't strictly necessary anyway.
Suppress NETSDK1138 warning when targeting .NET 6 in the integration tests.
The .NET 6 SDK is too old to support them.
Use `Task.Delay(0)` instead of `Task.Yield()`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LabelsWrapperto supportasyncand passing through state to avoid allocating closures (example usage).