Skip to content

fix(helm): Wrong context passed to loki.namespace helper from table manager servicemonitor #19544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(helm): Wrong context passed to loki.namespace helper from table manager servicemonitor #19544

wants to merge 1 commit into from
+3 −1

Conversation

jkroepke
Copy link
Contributor

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #19439

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@jkroepke jkroepke requested a review from a team as a code owner October 19, 2025 19:07
@jkroepke
Copy link
Contributor Author

@QuentinBisson please, ty.

QuentinBisson
QuentinBisson reviewed Oct 19, 2025
View reviewed changes
Copy link
Contributor

@QuentinBisson QuentinBisson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@QuentinBisson QuentinBisson QuentinBisson left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

size/XS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Wrong context passed to loki.namespace helper from table manager servicemonitor

2 participants

@jkroepke @QuentinBisson