Integrations Cleanup and Updates #1197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The namespaces property is already supported by the ksm helm chart, but wasn't documented in the k8s chart
Ensured that only a leading or trailing space is removed when the timestamp is scrubbed
petewall
reviewed
Feb 3, 2025
charts/k8s-monitoring/charts/feature-cluster-metrics/values.yaml
Outdated
Show resolved
Hide resolved
Co-authored-by: Pete Wall <[email protected]>
* Fix a few things: * Pod Logs annotations and labels * Turn off authentication for Grafana in integration tests * Fix validation messages and check for pod logs Signed-off-by: Pete Wall <[email protected]> * Fix test Signed-off-by: Pete Wall <[email protected]> --------- Signed-off-by: Pete Wall <[email protected]>
* Added otlp-gateway as part of validation check * updated check to use regex instead of contains * added tempo checks * Fixed metrics/logs messaging
Signed-off-by: Robbie Lankford <[email protected]>
utilize dig that handles undefined fields Signed-off-by: Pete Wall <[email protected]>
Signed-off-by: Robbie Lankford <[email protected]>
…rics" to 0.5.13 (#1194) Co-authored-by: petewall <[email protected]>
…to 0.5.13 (#1195) Co-authored-by: petewall <[email protected]>
* add application-observability platform test --------- Signed-off-by: Robbie Lankford <[email protected]>
* Initial commit for tempo integration. * Adding in tempo integration tests * Update to default allow list for metrics Don't have the default allow list currently, so blanking it out while I compile it. * Adding default metric allow list * Fix to tempo integration test * Add in tempo single binary deployment for tests * removing test values file * updating generated files * Fix to test for keep_metrics with tempo integration * Updating port name for metrics collection in tempo integration test. * updating output.yaml for tempo integration test * Test fix - port name for tempo-monolith is different than tempo distributed
* Add validation for otlp destination protocol Signed-off-by: Pete Wall <[email protected]> * Update charts/k8s-monitoring/tests/destination_validations_test.yaml Co-authored-by: Robert Lankford <[email protected]> * Actually test the right error message Signed-off-by: Pete Wall <[email protected]> --------- Signed-off-by: Pete Wall <[email protected]> Co-authored-by: Robert Lankford <[email protected]>
Signed-off-by: Pete Wall <[email protected]>
Signed-off-by: Pete Wall <[email protected]>
* update default batch size in feature-application-observability Signed-off-by: Robbie Lankford <[email protected]> * update tests and generated files --------- Signed-off-by: Robbie Lankford <[email protected]>
Signed-off-by: Robbie Lankford <[email protected]>
* Make it possible to skip mysql logs integration Signed-off-by: Pete Wall <[email protected]> * Catch more instances Signed-off-by: Pete Wall <[email protected]> --------- Signed-off-by: Pete Wall <[email protected]>
Signed-off-by: Pete Wall <[email protected]>
Signed-off-by: Pete Wall <[email protected]>
* Fix a few things: * Pod Logs annotations and labels * Turn off authentication for Grafana in integration tests * Fix validation messages and check for pod logs Signed-off-by: Pete Wall <[email protected]> * Fix test Signed-off-by: Pete Wall <[email protected]> --------- Signed-off-by: Pete Wall <[email protected]>
Signed-off-by: Pete Wall <[email protected]>
…eanup # Conflicts: # charts/k8s-monitoring/charts/feature-integrations/docs/integrations/tempo.md # charts/k8s-monitoring/charts/feature-integrations/integrations/tempo-values.yaml # charts/k8s-monitoring/charts/feature-integrations/schema-mods/definitions/tempo-integration.schema.json # charts/k8s-monitoring/charts/feature-integrations/templates/_integration_tempo_logs.tpl # charts/k8s-monitoring/charts/feature-integrations/templates/_integration_tempo_metrics.tpl # charts/k8s-monitoring/charts/feature-integrations/tests/tempo_logs_test.yaml # charts/k8s-monitoring/charts/feature-integrations/tests/tempo_metrics_test.yaml # charts/k8s-monitoring/charts/feature-integrations/values.schema.json # charts/k8s-monitoring/charts/feature-pod-logs/templates/_common_pod_discovery.alloy.tpl # charts/k8s-monitoring/charts/feature-pod-logs/tests/default_test.yaml # charts/k8s-monitoring/docs/examples/auth/bearer-token/alloy-logs.alloy # charts/k8s-monitoring/docs/examples/auth/bearer-token/output.yaml # charts/k8s-monitoring/docs/examples/auth/embedded-secrets/alloy-logs.alloy # charts/k8s-monitoring/docs/examples/auth/embedded-secrets/output.yaml # charts/k8s-monitoring/docs/examples/auth/external-secrets/alloy-logs.alloy # charts/k8s-monitoring/docs/examples/auth/external-secrets/output.yaml # charts/k8s-monitoring/docs/examples/auth/oauth2/alloy-logs.alloy # charts/k8s-monitoring/docs/examples/auth/oauth2/output.yaml # charts/k8s-monitoring/docs/examples/collector-storage/alloy-logs.alloy # charts/k8s-monitoring/docs/examples/collector-storage/output.yaml # charts/k8s-monitoring/docs/examples/destinations/otlp-endpoint/alloy-logs.alloy # charts/k8s-monitoring/docs/examples/destinations/otlp-endpoint/output.yaml # charts/k8s-monitoring/docs/examples/extra-rules/alloy-logs.alloy # charts/k8s-monitoring/docs/examples/extra-rules/output.yaml # charts/k8s-monitoring/docs/examples/features/cluster-metrics/control-plane-monitoring/alloy-logs.alloy # charts/k8s-monitoring/docs/examples/features/cluster-metrics/control-plane-monitoring/output.yaml # charts/k8s-monitoring/docs/examples/features/integrations/grafana/alloy-logs.alloy # charts/k8s-monitoring/docs/examples/features/integrations/grafana/output.yaml # charts/k8s-monitoring/docs/examples/features/integrations/loki/alloy-logs.alloy # charts/k8s-monitoring/docs/examples/features/integrations/loki/output.yaml # charts/k8s-monitoring/docs/examples/features/integrations/mimir/alloy-logs.alloy # charts/k8s-monitoring/docs/examples/features/integrations/mimir/output.yaml # charts/k8s-monitoring/docs/examples/features/integrations/mysql/alloy-logs.alloy # charts/k8s-monitoring/docs/examples/features/integrations/mysql/output.yaml # charts/k8s-monitoring/docs/examples/features/pod-logs/default/alloy-logs.alloy # charts/k8s-monitoring/docs/examples/features/pod-logs/default/output.yaml # charts/k8s-monitoring/docs/examples/meta-monitoring/alloy-singleton.alloy # charts/k8s-monitoring/docs/examples/meta-monitoring/output.yaml # charts/k8s-monitoring/docs/examples/platforms/azure-aks/alloy-logs.alloy # charts/k8s-monitoring/docs/examples/platforms/azure-aks/output.yaml # charts/k8s-monitoring/docs/examples/platforms/eks-fargate/alloy-logs.alloy # charts/k8s-monitoring/docs/examples/platforms/eks-fargate/output.yaml # charts/k8s-monitoring/docs/examples/platforms/gke-autopilot/alloy-logs.alloy # charts/k8s-monitoring/docs/examples/platforms/gke-autopilot/output.yaml # charts/k8s-monitoring/docs/examples/platforms/openshift/alloy-logs.alloy # charts/k8s-monitoring/docs/examples/platforms/openshift/output.yaml # charts/k8s-monitoring/docs/examples/pod-labels-and-annotations/alloy-logs.alloy # charts/k8s-monitoring/docs/examples/pod-labels-and-annotations/output.yaml # charts/k8s-monitoring/docs/examples/private-image-registries/globally/alloy-logs.alloy # charts/k8s-monitoring/docs/examples/private-image-registries/globally/output.yaml # charts/k8s-monitoring/docs/examples/proxies/alloy-logs.alloy # charts/k8s-monitoring/docs/examples/proxies/output.yaml # charts/k8s-monitoring/docs/examples/tolerations/alloy-logs.alloy # charts/k8s-monitoring/docs/examples/tolerations/output.yaml # charts/k8s-monitoring/tests/integration/auth/.rendered/output.yaml # charts/k8s-monitoring/tests/integration/cluster-monitoring/.rendered/output.yaml # charts/k8s-monitoring/tests/integration/control-plane-monitoring/.rendered/output.yaml # charts/k8s-monitoring/tests/integration/integration-grafana/.rendered/output.yaml # charts/k8s-monitoring/tests/integration/integration-loki/.rendered/output.yaml # charts/k8s-monitoring/tests/integration/integration-mysql/.rendered/output.yaml # charts/k8s-monitoring/tests/integration/integration-tempo/.rendered/output.yaml # charts/k8s-monitoring/tests/integration/istio-service-mesh/.rendered/output.yaml # charts/k8s-monitoring/tests/integration/pod-logs/.rendered/output.yaml # charts/k8s-monitoring/tests/integration/split-destinations/.rendered/output.yaml # charts/k8s-monitoring/tests/platform/eks-with-windows/.rendered/output.yaml # charts/k8s-monitoring/tests/platform/gke-autopilot/.rendered/output.yaml # charts/k8s-monitoring/tests/platform/grafana-cloud/app-observability/.rendered/output.yaml # charts/k8s-monitoring/tests/platform/grafana-cloud/k8s-monitoring/.rendered/output.yaml
petewall
approved these changes
Feb 12, 2025
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.