Update golangci-lint to v2.5.0 #5209
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This seems to be the most ... not terrible way to do it. Doing it with `//nolint` requires line everywhere and then nolintlint complains. Disabling it as a rule of `revive` disables all other rules.
mstoykov
requested review from
ankur22 and
AgnesToulet
and removed request for
a team
|
Better to go commit by commit as they are split based on similar problems/reports. |
mstoykov
temporarily deployed
to
azure-trusted-signing
GitHub Actions
Inactive
mstoykov
temporarily deployed
to
azure-trusted-signing
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Update to latet golangci-lint v2.5.0
Why?
Both to update the version and fix issues earlier, but also because we need newer version to work with go 1.25, and not have local issues that do not happen in CI.
Checklist
make check) and all pass.Checklist: Documentation (only for k6 maintainers and if relevant)
Please do not merge this PR until the following items are filled out.
Related PR(s)/Issue(s)