Skip to content

Conversation

codebien
Copy link
Contributor

@codebien codebien commented Sep 25, 2025

What?

Do not update indirect deps

Why?

We don't need Renovate to update indirect deps

Checklist

  • I have performed a self-review of my code.
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have added tests for my changes.
  • I have run linter and tests locally (make check) and all pass.

Checklist: Documentation (only for k6 maintainers and if relevant)

Please do not merge this PR until the following items are filled out.

  • I have added the correct milestone and labels to the PR.
  • I have updated the release notes: link
  • I have updated or added an issue to the k6-documentation: grafana/k6-docs#NUMBER if applicable
  • I have updated or added an issue to the TypeScript definitions: grafana/k6-DefinitelyTyped#NUMBER if applicable

Related PR(s)/Issue(s)

@codebien codebien self-assigned this Sep 25, 2025
@codebien codebien temporarily deployed to azure-trusted-signing September 25, 2025 08:55 — with GitHub Actions Inactive
@codebien codebien temporarily deployed to azure-trusted-signing September 25, 2025 08:56 — with GitHub Actions Inactive
Copy link
Contributor

@mstoykov mstoykov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can we merge it :P

@codebien codebien force-pushed the renovate-exclude-indirects branch from 58646af to 63177cb Compare October 14, 2025 12:38
@codebien codebien marked this pull request as ready for review October 14, 2025 12:39
@codebien codebien requested a review from a team as a code owner October 14, 2025 12:39
@codebien codebien requested review from ankur22 and oleiade and removed request for a team October 14, 2025 12:39
@codebien codebien temporarily deployed to azure-trusted-signing October 14, 2025 12:44 — with GitHub Actions Inactive
@codebien codebien temporarily deployed to azure-trusted-signing October 14, 2025 12:46 — with GitHub Actions Inactive
ankur22
ankur22 previously approved these changes Oct 14, 2025
mstoykov
mstoykov previously approved these changes Oct 14, 2025
@codebien codebien dismissed stale reviews from mstoykov and ankur22 via 1a5be25 October 14, 2025 13:53
@codebien codebien requested review from ankur22 and mstoykov October 14, 2025 13:54
@codebien codebien merged commit 1473104 into master Oct 14, 2025
34 checks passed
@codebien codebien deleted the renovate-exclude-indirects branch October 14, 2025 13:59
@codebien codebien temporarily deployed to azure-trusted-signing October 14, 2025 13:59 — with GitHub Actions Inactive
@codebien codebien temporarily deployed to azure-trusted-signing October 14, 2025 14:01 — with GitHub Actions Inactive
@mstoykov mstoykov added this to the v1.4.0 milestone Oct 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants