Skip to content

Conversation

vincentandreas
Copy link

What?

Implement throw exception in RSA PSS, when given salt length = 0, in Sign / Verify function

Why?

It improves UX and makes implementation predictable.

Checklist

  • I have performed a self-review of my code.
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have added tests for my changes.
  • I have run linter and tests locally (make check) and all pass.

Checklist: Documentation (only for k6 maintainers and if relevant)

Please do not merge this PR until the following items are filled out.

  • I have added the correct milestone and labels to the PR.
  • I have updated the release notes: link
  • I have updated or added an issue to the k6-documentation: grafana/k6-docs#NUMBER if applicable
  • I have updated or added an issue to the TypeScript definitions: grafana/k6-DefinitelyTyped#NUMBER if applicable

Related PR(s)/Issue(s)

Issues #4265
Previous PR #4659

@vincentandreas vincentandreas requested a review from a team as a code owner September 5, 2025 14:45
@vincentandreas vincentandreas requested review from AgnesToulet and joanlopez and removed request for a team September 5, 2025 14:45
Copy link
Contributor

@AgnesToulet AgnesToulet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! Sorry for the delay and thanks a lot for your contribution!

This looks good (just left some wording suggestions) and works great but we probably want to update the tests in this case to expect the error, could you update your PR with updated tests please?

@vincentandreas
Copy link
Author

hi @AgnesToulet , thankyou for the feedback! I'll add that later.

@vincentandreas
Copy link
Author

hi @AgnesToulet could you elaborate, which file that contain test that need to be updated?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants