Skip to content

[rollout-operator] Replace default webhooks.selfSignedCertSecretName with fullname #3990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+6 −6
Open

[rollout-operator] Replace default webhooks.selfSignedCertSecretName with fullname #3990

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2cb15fb
[rollout-operator] Unset default webhooks.selfSignedCertSecretName an…
kimxogus Nov 5, 2025
3be3078
Merge branch 'main' into feature/remove-default-secret-name
Sheikh-Abubaker Nov 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/rollout-operator/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ apiVersion: v2
name: rollout-operator
description: "Grafana rollout-operator"
type: application
version: 0.37.1
version: 0.38.0
appVersion: v0.32.0
home: https://github.com/grafana/rollout-operator
kubeVersion: ^1.10.0-0
4 changes: 2 additions & 2 deletions charts/rollout-operator/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ Helm chart for deploying [Grafana rollout-operator](https://github.com/grafana/r

# rollout-operator

![Version: 0.37.1](https://img.shields.io/badge/Version-0.37.1-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: v0.32.0](https://img.shields.io/badge/AppVersion-v0.32.0-informational?style=flat-square)
![Version: 0.38.0](https://img.shields.io/badge/Version-0.38.0-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: v0.32.0](https://img.shields.io/badge/AppVersion-v0.32.0-informational?style=flat-square)

Grafana rollout-operator

Expand Down Expand Up @@ -85,4 +85,4 @@ Manually applying these CRDs is only required if upgrading from a chart <= v0.32
| tolerations | list | `[]` | |
| webhooks.enabled | bool | `true` | Enable the rollout-operator webhooks. See https://github.com/grafana/rollout-operator/#webhooks. Note that the webhooks require custom resource definitions. If upgrading, manually apply the files in the `crds` directory. |
| webhooks.failurePolicy | string | `"Fail"` | Validating and mutating webhook failure policy. `Ignore` or `Fail`. |
| webhooks.selfSignedCertSecretName | string | `"certificate"` | Secret resource name for the TLS certificate to be used with the webhooks |
| webhooks.selfSignedCertSecretName | string | `""` | Secret resource name for the TLS certificate to be used with the webhooks |
2 changes: 1 addition & 1 deletion charts/rollout-operator/templates/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ spec:
- -kubernetes.namespace={{ .Release.Namespace }}
{{- if .Values.webhooks.enabled }}
- -server-tls.enabled=true
- -server-tls.self-signed-cert.secret-name={{ .Values.webhooks.selfSignedCertSecretName }}
- -server-tls.self-signed-cert.secret-name={{ .Values.webhooks.selfSignedCertSecretName | default (include "rollout-operator.fullname" . ) }}
Copy link
Contributor

@dimitarvdimitrov dimitarvdimitrov Nov 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can {{ .Values.webhooks.selfSignedCertSecretName | default (include "rollout-operator.fullname" . ) }} maybe go in a named template in _helpers.tpl? that way we don't have to remember to update it in multiple places next time

- -server-tls.self-signed-cert.dns-name={{ include "rollout-operator.fullname" . }}.{{ .Release.Namespace }}.svc
{{- end }}
{{- range .Values.extraArgs }}
Expand Down
2 changes: 1 addition & 1 deletion charts/rollout-operator/templates/webhook-role.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ rules:
- update
- get
resourceNames:
- {{ .Values.webhooks.selfSignedCertSecretName }}
- {{ .Values.webhooks.selfSignedCertSecretName | default (include "rollout-operator.fullname" . ) }}
- apiGroups:
- ""
resources:
Expand Down
2 changes: 1 addition & 1 deletion charts/rollout-operator/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,4 +107,4 @@ webhooks:
# -- Validating and mutating webhook failure policy. `Ignore` or `Fail`.
failurePolicy: "Fail"
# -- Secret resource name for the TLS certificate to be used with the webhooks
Copy link
Contributor

@dimitarvdimitrov dimitarvdimitrov Nov 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you clarify what the default is if this value is empty?

selfSignedCertSecretName: "certificate"
selfSignedCertSecretName: ""
Loading