Skip to content

Chore(Helm): Align Helm with Kustomize by enabling leader-election. #1944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion deploy/helm/grafana-operator/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ It's easier to just manage this configuration outside of the operator.
| image.tag | string | `""` | Overrides the image tag whose default is the chart appVersion. |
| imagePullSecrets | list | `[]` | image pull secrets |
| isOpenShift | bool | `false` | Determines if the target cluster is OpenShift. Additional rbac permissions for routes will be added on OpenShift |
| leaderElect | bool | `false` | If you want to run multiple replicas of the grafana-operator, this is not recommended. |
| leaderElect | bool | `true` | This is recommended in most scenarios, even when only running a single instance of the operator. |
| logging.encoder | string | `"console"` | Log encoding ("console", "json") |
| logging.level | string | `"info"` | Configure the verbosity of logging ("debug", "error", "info") |
| logging.time | string | `"rfc3339"` | Time encoding ("epoch", "iso8601", "millis", "nano", "rfc3339", "rfc3339nano") |
Expand Down
23 changes: 0 additions & 23 deletions deploy/helm/grafana-operator/templates/cm.yaml

This file was deleted.

4 changes: 2 additions & 2 deletions deploy/helm/grafana-operator/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@
# if true the operator will only be able to manage instances in the same namespace
namespaceScope: false

# -- If you want to run multiple replicas of the grafana-operator, this is not recommended.
leaderElect: false
# -- This is recommended in most scenarios, even when only running a single instance of the operator.
leaderElect: true

# -- Sets the `WATCH_NAMESPACE` environment variable,
# it defines which namespaces the operator should be listening for (e.g. `"grafana, foo"`).
Expand Down
Loading