Beyla 2.2 #3610
Merged
Beyla 2.2 #3610
+58
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💻 Deploy preview deleted. |
|
I think that this PR should be targeted at the Otel upgrade PR no? |
yeah, but i wanted to open this PR to see if the integration tests are passing (and is not the case actually!) |
clayton-cornell
approved these changes
May 20, 2025
wildum
approved these changes
May 21, 2025
clayton-cornell
added
the
type/docs
| @@ -262,6 +274,7 @@ the instrumented processes need to match all the selector properties. | |||
| | `namespace` | `string` | Regular expression of Kubernetes Namespaces to match. | `""` | no | | |||
| | `owner_name` | `string` | Regular expression of Kubernetes owners of running Pods to match. | `""` | no | | |||
| | `pod_labels` | `map(string)` | Key-value pairs of labels with keys matching Kubernetes Pods with the provided value as regular expression. | `{}` | no | | |||
| | `pod_annotations` | `map(string)` | Key-value pairs of labels with keys matching Kubernetes annotations with the provided value as regular expression. | `{}` | no | | |||
There was a problem hiding this comment.
Suggested change
| | `pod_annotations` | `map(string)` | Key-value pairs of labels with keys matching Kubernetes annotations with the provided value as regular expression. | `{}` | no | | |
| | `pod_annotations` | `map(string)` | Key-value pairs of labels with keys matching Kubernetes annotations with the provided value as regular expression. | `{}` | no | |
One REALLY small spacing suggestion. If it's not included in this PR it's not a big deal :-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
PR Checklist