Upgrade OpenTelemetry components from v0.122.0 to v0.125.0 #3489
Conversation
|
💻 Deploy preview available: |
internal/converter/internal/otelcolconvert/testdata/spanmetrics_full.alloy
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
I don't know why the sizer and retry_on_failure differences occur. Those parameters do have default values in the upstream collector.
There was a problem hiding this comment.
The reason is that the defaults are not set upstream at this level, they are only set within the protocol. See: https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/exporter/loadbalancingexporter/factory.go#L42
There was a problem hiding this comment.
But Alloy's LB exporter doesn't set defaults for sending_queue. So I can't explain to myself why the converter thinks Alloy doesn't use the 0 values.
internal/component/otelcol/exporter/loadbalancing/loadbalancing.go
Outdated
Show resolved
Hide resolved
ptodev
force-pushed
the
ptodev/update-otel
branch
4 times, most recently
from
6cf8d81 to
6fedcc8
Compare
ptodev
force-pushed
the
ptodev/update-otel
branch
6 times, most recently
from
b7e5133 to
22ba0b7
Compare
| - [`otelcol.connector.spanmetrics`] Moving the start timestamp (and last seen timestamp) from the resourceMetrics level to the individual metrics level. | ||
| - [`otelcol.processor.k8sattributes`] Add option to configure automatic resource attributes - with annotation prefix. | ||
| Implements [Specify resource attributes using Kubernetes annotations](https://github.com/open-telemetry/semantic-conventions/blob/main/docs/non-normative/k8s-attributes.md#specify-resource-attributes-using-kubernetes-annotations). | ||
| This will ensure that each metric has its own accurate start and last seen timestamps, regardless of its relationship to other spans. |
There was a problem hiding this comment.
Is this line in the right place?
There was a problem hiding this comment.
I think so. Why would it not be?
There was a problem hiding this comment.
Doesn't it belong to the spanmetrics changelog on 107?
There was a problem hiding this comment.
Not sure what you mean? It is from v0.124.0.
docs/sources/reference/components/otelcol/otelcol.exporter.awss3.md
Outdated
Show resolved
Hide resolved
docs/sources/reference/components/otelcol/otelcol.exporter.kafka.md
Outdated
Show resolved
Hide resolved
docs/sources/reference/components/otelcol/otelcol.exporter.kafka.md
Outdated
Show resolved
Hide resolved
docs/sources/reference/components/otelcol/otelcol.receiver.kafka.md
Outdated
Show resolved
Hide resolved
docs/sources/reference/components/otelcol/otelcol.receiver.kafka.md
Outdated
Show resolved
Hide resolved
docs/sources/reference/components/otelcol/otelcol.receiver.kafka.md
Outdated
Show resolved
Hide resolved
| } | ||
| if len(c.Encoding) > 0 { | ||
| result.Encoding = c.Encoding | ||
| } |
There was a problem hiding this comment.
If the block is not nil, should we pass through and potentially use the deprecated field defaults?
There was a problem hiding this comment.
No. The intent here is to always use the block's explicit or default values if the block is explicitly defined. That way we could document it in a simple way - if the block exists, use the block values. It shouldn't matter if the defaults or if the explicit values are used.
There was a problem hiding this comment.
The current behavior appears to fall through and use the default value of the deprecated fields if the provided values are len 0
There was a problem hiding this comment.
Ah I see! Those are not the deprecated field defaults. Those are the defaults to use if neither the deprecated nor the "new" field has a non-empty value. I added comments to make this more clear. The confusion comes from the name of the deprecatedArg struct... but I don't know what else to call it?
ptodev
force-pushed
the
ptodev/update-otel
branch
from
e5bde2d to
2d69c27
Compare
There was a problem hiding this comment.
A few suggestions and comments - most are formatting related to align with the formatting changes in #3583
docs/sources/reference/components/otelcol/otelcol.auth.bearer.md
Outdated
Show resolved
Hide resolved
docs/sources/reference/components/otelcol/otelcol.connector.servicegraph.md
Outdated
Show resolved
Hide resolved
docs/sources/reference/components/otelcol/otelcol.exporter.awss3.md
Outdated
Show resolved
Hide resolved
docs/sources/reference/components/otelcol/otelcol.exporter.awss3.md
Outdated
Show resolved
Hide resolved
docs/sources/shared/reference/components/otelcol-kafka-metadata.md
Outdated
Show resolved
Hide resolved
docs/sources/shared/reference/components/otelcol-queue-block.md
Outdated
Show resolved
Hide resolved
docs/sources/shared/reference/components/otelcol-queue-block.md
Outdated
Show resolved
Hide resolved
docs/sources/shared/reference/components/otelcol-queue-block.md
Outdated
Show resolved
Hide resolved
docs/sources/shared/reference/components/otelcol-queue-block.md
Outdated
Show resolved
Hide resolved
clayton-cornell
added
the
type/docs
ptodev
force-pushed
the
ptodev/update-otel
branch
4 times, most recently
from
2b523a9 to
60a7718
Compare
ptodev
force-pushed
the
ptodev/update-otel
branch
from
4b92e1a to
f475e97
Compare
PR Description
Routine update for the next Alloy release.
PR Checklist