Skip to content

build(deps): bump github.com/snowflakedb/gosnowflake from 1.7.2-0.20240103203018-f1d625f17408 to 1.13.3 #3467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Apr 29, 2025

Bumps github.com/snowflakedb/gosnowflake from 1.7.2-0.20240103203018-f1d625f17408 to 1.13.3.

Release notes

Sourced from github.com/snowflakedb/gosnowflake's releases.

Release

Release

Release

Release

Release

Release

Release

Release

Release

Release

Release

Release

Release

Release

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
    You can disable automated security fix PRs for this repo from the Security Alerts page.

@dependabot dependabot bot added dependencies Pull requests that update a dependency file go Pull requests that update Go code labels Apr 29, 2025
@dependabot dependabot bot requested a review from a team as a code owner April 29, 2025 02:06
@jharvey10
Copy link
Contributor

@dependabot rebase

@dependabot dependabot bot force-pushed the dependabot/go_modules/github.com/snowflakedb/gosnowflake-1.13.3 branch 2 times, most recently from 64446c1 to 9a01341 Compare May 9, 2025 14:56
@jharvey10
Copy link
Contributor

Closing this PR temporarily to test if it can be done by renovate instead.

@jharvey10 jharvey10 closed this May 9, 2025
Copy link
Contributor Author

dependabot bot commented on behalf of github May 9, 2025

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/go_modules/github.com/snowflakedb/gosnowflake-1.13.3 branch May 9, 2025 18:11
@jharvey10 jharvey10 restored the dependabot/go_modules/github.com/snowflakedb/gosnowflake-1.13.3 branch May 12, 2025 21:03
@jharvey10 jharvey10 reopened this May 12, 2025
@jharvey10
Copy link
Contributor

@dependabot rebase

Bumps [github.com/snowflakedb/gosnowflake](https://github.com/snowflakedb/gosnowflake) from 1.7.2-0.20240103203018-f1d625f17408 to 1.13.3.
- [Release notes](https://github.com/snowflakedb/gosnowflake/releases)
- [Changelog](https://github.com/snowflakedb/gosnowflake/blob/master/release.go)
- [Commits](https://github.com/snowflakedb/gosnowflake/commits/v1.13.3)

---
updated-dependencies:
- dependency-name: github.com/snowflakedb/gosnowflake
  dependency-version: 1.13.3
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/go_modules/github.com/snowflakedb/gosnowflake-1.13.3 branch from 9a01341 to 131212b Compare May 12, 2025 21:10
@rgoltz
Copy link
Contributor

rgoltz commented May 13, 2025

Hi @jharvey10 - Thanks for working on the update of github.com/snowflakedb/gosnowflake to resolve CVE-2025-46327. In the context of this update, I created PR #3528, which will update github.com/grafana/snowflake-prometheus-exporter (which is/was using this older version of github.com/snowflakedb/gosnowflake).

The PR #3528 might overlap with this PR, but I think is better to update the github.com/grafana/snowflake-prometheus-exporter as well, since after this PR grafana/snowflake-prometheus-exporter#28 it's now using the updated github.com/snowflakedb/gosnowflake. The PR here from dependabot didn't cover the update of github.com/grafana/snowflake-prometheus-exporter yet. Hence a look into the PR #3528 might make sense.

@jharvey10
Copy link
Contributor

@rgoltz Hey! Thanks for the context! I'm by no means an expert in go module stuff, but could you talk me through the need to update github.com/grafana/snowflake-prometheus-exporter as a part of the PR you opened?

I'm not opposed to it, and as a general goal I want to get all of our dependencies up to date, but looking through our go.sum file on this (dependabot) PR, I'm not seeing any references to versions older than 1.13.3.

My thought here (applying my npm knowledge 😅) is that since the previous dep requirement in snowflake-prometheus-exporter was github.com/snowflakedb/gosnowflake v1.6.19, this would mean 1.6.19 or higher, which in the context of Alloy would mean that moving github.com/snowflakedb/gosnowflake up to 1.13.3 would satisfy this requirement as well, with the net result being that both of them would now use 1.13.3 in the Alloy repo/module.

I hope that makes sense. I could totally be missing something here, but it would be great if you could check my understanding.

@jharvey10 jharvey10 merged commit 29232fb into main May 21, 2025
37 checks passed
@jharvey10 jharvey10 deleted the dependabot/go_modules/github.com/snowflakedb/gosnowflake-1.13.3 branch May 21, 2025 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file go Pull requests that update Go code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants