Updated README and Java sources. #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested a review
from
ghost
commented
Jun 8, 2022
|
|
||
|  | ||
| ```shell | ||
| ```bash | ||
| mvn package -Pnative |
There was a problem hiding this comment.
Should we tell the user to ignore the warnings here?
ghost
commented
Jun 8, 2022
|
|
||
|  | ||
| ```shell | ||
| ```bash | ||
| # Build a Docker Image | ||
| docker build -f ./01-native-image/Dockerfile \ |
There was a problem hiding this comment.
This required me to allocate more memory to docker (12G) to enable it to build.
ghost
commented
Jun 8, 2022
| @@ -556,20 +539,21 @@ te snippet from the `distroless` profile in the `pom.xml` that passes this param | |||
| </buildArgs> | |||
| ``` | |||
|
|
|||
| You can build your mostly statically linked native executable as follows - be aware this will only work on Linux. We will | |||
| You can build your mostly-statically linked native executable as follows--be aware this will only work on Linux. We will | |||
There was a problem hiding this comment.
I think this needs to be rewritten somehow. It implies that you can't run the command but then provides the command. Perhaps it should just be deleted?
ghost
commented
Jun 8, 2022
|
|
||
|  | ||
| ```shell | ||
| ```bash | ||
| # Build a Docker Image | ||
| docker build -f ./02-smaller-containers/Dockerfile \ |
There was a problem hiding this comment.
This required me to allocate more memory to docker (12G) to enable it to build.
ghost
commented
Jun 8, 2022
| @@ -654,32 +641,49 @@ docker run --rm -d --name "jibber-distroless" -p 8080:8080 jibber:distroless.01 | |||
| ```shell | |||
| curl http://localhost:8080/jibber | |||
| ``` | |||
| And let's clean up after ourselves by killing the running container. | |||
|
|
|||
| <!-- I added this section, but I don't have the numbers --> | |||
There was a problem hiding this comment.
This section needs reviewing by @krisfoster.
I managed to get the builds to work by allocating more memory to docker.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.