Skip to content

Commit eca504c

Browse files
committed
[GR-59700] Set JVMCI_VERSION_CHECK to ignore when calling a fetch-jdk provider.
PullRequest: mx/1851
2 parents c814bf9 + 362c362 commit eca504c

File tree

3 files changed

+19
-11
lines changed

3 files changed

+19
-11
lines changed

common.json

+9-9
Original file line numberDiff line numberDiff line change
@@ -4,11 +4,11 @@
44
"Jsonnet files should not include this file directly but use ci/common.jsonnet instead."
55
],
66

7-
"mx_version": "7.33.1",
7+
"mx_version": "7.34.1",
88

99
"COMMENT.jdks": "When adding or removing JDKs keep in sync with JDKs in ci/common.jsonnet",
1010
"jdks": {
11-
"galahad-jdk": {"name": "jpg-jdk", "version": "24", "build_id": "jdk-24+21-2436", "platformspecific": true, "extrabundles": ["static-libs"]},
11+
"galahad-jdk": {"name": "jpg-jdk", "version": "24", "build_id": "jdk-24+22-2651", "platformspecific": true, "extrabundles": ["static-libs"]},
1212

1313
"oraclejdk17": {"name": "jpg-jdk", "version": "17.0.7", "build_id": "jdk-17.0.7+8", "platformspecific": true, "extrabundles": ["static-libs"]},
1414
"labsjdk-ce-17": {"name": "labsjdk", "version": "ce-17.0.7+4-jvmci-23.1-b02", "platformspecific": true },
@@ -45,13 +45,13 @@
4545

4646
"oraclejdk23": {"name": "jpg-jdk", "version": "23", "build_id": "jdk-23+37", "platformspecific": true, "extrabundles": ["static-libs"]},
4747

48-
"oraclejdk-latest": {"name": "jpg-jdk", "version": "24", "build_id": "jdk-24+21", "platformspecific": true, "extrabundles": ["static-libs"]},
49-
"labsjdk-ce-latest": {"name": "labsjdk", "version": "ce-24+21-jvmci-b01", "platformspecific": true },
50-
"labsjdk-ce-latestDebug": {"name": "labsjdk", "version": "ce-24+21-jvmci-b01-debug", "platformspecific": true },
51-
"labsjdk-ce-latest-llvm": {"name": "labsjdk", "version": "ce-24+21-jvmci-b01-sulong", "platformspecific": true },
52-
"labsjdk-ee-latest": {"name": "labsjdk", "version": "ee-24+21-jvmci-b01", "platformspecific": true },
53-
"labsjdk-ee-latestDebug": {"name": "labsjdk", "version": "ee-24+21-jvmci-b01-debug", "platformspecific": true },
54-
"labsjdk-ee-latest-llvm": {"name": "labsjdk", "version": "ee-24+21-jvmci-b01-sulong", "platformspecific": true }
48+
"oraclejdk-latest": {"name": "jpg-jdk", "version": "24", "build_id": "jdk-24+22", "platformspecific": true, "extrabundles": ["static-libs"]},
49+
"labsjdk-ce-latest": {"name": "labsjdk", "version": "ce-24+22-jvmci-b01", "platformspecific": true },
50+
"labsjdk-ce-latestDebug": {"name": "labsjdk", "version": "ce-24+22-jvmci-b01-debug", "platformspecific": true },
51+
"labsjdk-ce-latest-llvm": {"name": "labsjdk", "version": "ce-24+22-jvmci-b01-sulong", "platformspecific": true },
52+
"labsjdk-ee-latest": {"name": "labsjdk", "version": "ee-24+22-jvmci-b01", "platformspecific": true },
53+
"labsjdk-ee-latestDebug": {"name": "labsjdk", "version": "ee-24+22-jvmci-b01-debug", "platformspecific": true },
54+
"labsjdk-ee-latest-llvm": {"name": "labsjdk", "version": "ee-24+22-jvmci-b01-sulong", "platformspecific": true }
5555
},
5656

5757
"eclipse": {

src/mx/_impl/mx.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -18215,7 +18215,7 @@ def alarm_handler(signum, frame):
1821518215
_CACHE_DIR = get_env('MX_CACHE_DIR', join(dot_mx_dir(), 'cache'))
1821618216

1821718217
# The version must be updated for every PR (checked in CI) and the comment should reflect the PR's issue
18218-
version = VersionSpec("7.34.1") # [GR-58270] lazily check benchmark VM configs
18218+
version = VersionSpec("7.34.2") # [GR-59700] set JVMCI_VERSION_CHECK to ignore when calling a fetch-jdk provider
1821918219

1822018220
_mx_start_datetime = datetime.utcnow()
1822118221

src/mx/_impl/mx_fetchjdk.py

+9-1
Original file line numberDiff line numberDiff line change
@@ -668,7 +668,15 @@ def urls(self):
668668
infile = os.path.join(temp_dir, "fetch-jdk-provider-request.json")
669669
with open(infile, "w") as in_fp:
670670
in_fp.write(json_input)
671-
mx.run_mx([provider, infile, outfile], quiet=True)
671+
672+
# Since fetch-jdk is often run to get a more recent JAVA_HOME,
673+
# JVMCI_VERSION_CHECK should be set to "ignore" when calling a fetch-jdk
674+
# provider to prevent the JVMCI version check failing. A fetch-jdk provider
675+
# in a suite that has a JVMCI version check must not use JAVA_HOME.
676+
env = os.environ.copy()
677+
env["JVMCI_VERSION_CHECK"] = "ignore"
678+
679+
mx.run_mx([provider, infile, outfile], quiet=True, env=env)
672680
with open(outfile) as out_fp:
673681
return out_fp.read().splitlines()
674682

0 commit comments

Comments
 (0)