Skip to content

Commit c814bf9

Browse files
committed
[GR-58270] Hotfix for vm config resolution.
PullRequest: mx/1848
2 parents 76b13a9 + 9552f6d commit c814bf9

File tree

2 files changed

+8
-7
lines changed

2 files changed

+8
-7
lines changed

src/mx/_impl/mx.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -18215,7 +18215,7 @@ def alarm_handler(signum, frame):
1821518215
_CACHE_DIR = get_env('MX_CACHE_DIR', join(dot_mx_dir(), 'cache'))
1821618216

1821718217
# The version must be updated for every PR (checked in CI) and the comment should reflect the PR's issue
18218-
version = VersionSpec("7.34.0") # [GR-58270] Allow syntactic sugar to configure benchmark VM configs
18218+
version = VersionSpec("7.34.1") # [GR-58270] lazily check benchmark VM configs
1821918219

1822018220
_mx_start_datetime = datetime.utcnow()
1822118221

src/mx/_impl/mx_benchmark.py

+7-6
Original file line numberDiff line numberDiff line change
@@ -432,12 +432,13 @@ def add_vm(self, vm, suite=None, priority=0):
432432
def get_vm(self, vm_name, vm_config):
433433
resolved_name = None
434434
for (candidate_vm_name, candidate_vm_config), candidate_vm in self._vms.items():
435-
canonical_name = candidate_vm.canonical_config_name(vm_config)
436-
if vm_name == candidate_vm_name and canonical_name == candidate_vm_config:
437-
resolved_name = candidate_vm_config
438-
if vm_config != canonical_name:
439-
mx.log(f"Canonicalized the '{vm_config}' vm config to: {resolved_name}")
440-
break
435+
if vm_name == candidate_vm_name:
436+
canonical_name = candidate_vm.canonical_config_name(vm_config)
437+
if canonical_name == candidate_vm_config:
438+
resolved_name = candidate_vm_config
439+
if vm_config != canonical_name:
440+
mx.log(f"Canonicalized the '{vm_config}' vm config to: {resolved_name}")
441+
break
441442
key = (vm_name, resolved_name or vm_config)
442443
if key not in self._vms:
443444
mx.abort(f"{self.vm_type_name} and config '{key}' do not exist.\n{self.get_available_vm_configs_help()}")

0 commit comments

Comments
 (0)