Skip to content

Deploy nativeimage-libgraal.jar#515

Merged
jerboaa merged 1 commit intograalvm:masterfrom
jerboaa:add-libgraal-deploy
Feb 6, 2026
Merged

Deploy nativeimage-libgraal.jar#515
jerboaa merged 1 commit intograalvm:masterfrom
jerboaa:add-libgraal-deploy

Conversation

@jerboaa
Copy link
Copy Markdown
Collaborator

@jerboaa jerboaa commented Feb 6, 2026

It's a dependency of the native image builder in version 25. Deploy it so that it carries over from the Java to the native build.

Same deal as #514 yesterday.

See also:

It's a dependency of the native image builder in version 25. Deploy it
so that it carries over from the Java to the native build.
@oracle-contributor-agreement oracle-contributor-agreement Bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Feb 6, 2026
@jerboaa jerboaa requested a review from zakkak February 6, 2026 13:29
@jerboaa
Copy link
Copy Markdown
Collaborator Author

jerboaa commented Feb 6, 2026

If OK, I'll also cherry-pick to the 25.0 branch once it's been integrated. Checked with a local build with --maven-deploy-local and verified the nativeimage-libgraal.jar gets installed in the local maven repo.

@jerboaa jerboaa requested a review from Karm February 6, 2026 13:34
@zakkak
Copy link
Copy Markdown
Collaborator

zakkak commented Feb 6, 2026

Shouldn't this have been caught by our GHA that uses local maven ?

Cab we do anything to catch such issues in the future?

Copy link
Copy Markdown
Collaborator

@Karm Karm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jerboaa LGTM. I see no reason why not to have it.

@Karm
Copy link
Copy Markdown
Collaborator

Karm commented Feb 6, 2026

Shouldn't this have been caught by our GHA that uses local maven ?

Perhaps old artifacts are being picked thanks to cache?

@jerboaa
Copy link
Copy Markdown
Collaborator Author

jerboaa commented Feb 6, 2026

Shouldn't this have been caught by our GHA that uses local maven ?

I don't think so. We'd need to change the mandrel packaging script to use deployed artefacts in the 2-step-workflow. That's not yet the case. Since the build uses the one from mxbuild dir it's not seeing the issue.

Can we do anything to catch such issues in the future?

Probably. It's a bit annoying to re-create in CI though. Feel free to work on it.

@jerboaa
Copy link
Copy Markdown
Collaborator Author

jerboaa commented Feb 6, 2026

Thanks for the review!

@jerboaa jerboaa merged commit 92d2f73 into graalvm:master Feb 6, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

OCA Verified All contributors have signed the Oracle Contributor Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants