Skip to content

Run batchFinishedCallback on processBatch to catch unhandled rejections by test functions #3844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 15, 2024
Merged

Run batchFinishedCallback on processBatch to catch unhandled rejections by test functions #3844

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
85573fd
call batchFinishedCallback later to prevent timeouts on unhandled rej…
sagudev Jul 7, 2024
1a5648e
await onSubmittedWorkDone
sagudev Jul 13, 2024
894ad5e
Remove unnecessary void operator
kainino0x Jul 15, 2024
db3acfb
Merge branch 'main' into fix-reject-expr
kainino0x Jul 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/webgpu/shader/execution/expression/expression.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -413,7 +413,7 @@ export async function run(
};
const checkBatch = await submitBatch(t, shaderBuilder, shaderBuilderParams, pipelineCache);
checkBatch();
void t.queue.onSubmittedWorkDone().finally(batchFinishedCallback);
void t.queue.onSubmittedWorkDone();
};

const pendingBatches = [];
Expand All @@ -430,7 +430,7 @@ export async function run(
}
batchesInFlight += 1;

pendingBatches.push(processBatch(batchCases));
pendingBatches.push(processBatch(batchCases).finally(batchFinishedCallback));
}

await Promise.all(pendingBatches);
Expand Down