Skip to content

BAU: Add logging of NumberParseException type #6444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

BAU: Add logging of NumberParseException type #6444

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions shared/src/main/java/uk/gov/di/authentication/shared/helpers/PhoneNumberHelper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,9 @@ public static String formatPhoneNumber(String phoneNumber) {
var parsedPhoneNumber = phoneUtil.parse(phoneNumber, "GB");
return phoneUtil.format(parsedPhoneNumber, PhoneNumberUtil.PhoneNumberFormat.E164);
} catch (NumberParseException e) {
LOG.warn("Error when trying to parse phone number");
LOG.warn(
"Error when trying to parse phone number for formatPhoneNumber: {}",
e.getErrorType());
throw new RuntimeException(e);
}
}
Expand All @@ -27,7 +29,8 @@ public static String getCountry(String phoneNumber) {
return Integer.toString(
PhoneNumberUtil.getInstance().parse(phoneNumber, "GB").getCountryCode());
} catch (NumberParseException e) {
LOG.warn("Error when trying to parse phone number");
LOG.warn(
"Error when trying to parse phone number for getCountry: {}", e.getErrorType());
throw new RuntimeException(e);
}
}
Expand Down
Loading