Skip to content

AUT-4213: Give cross account access to dev dynamo DB table #6399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 8, 2025

Conversation

pskushwaha1
Copy link
Contributor

@pskushwaha1 pskushwaha1 commented Apr 24, 2025

What

AUT-4213

PR to add policy to dynamo DB for cross account table access

How to review

  1. Code Review

  2. Deploy to Dev env and verify the Dynamo DB tables permission to all table in Dev environment

  3. Deploy Account invention stub & TICF stub in authdevs

./deploy-authdevs.sh -i -p ( deploy the account interventions API stub) verify the Dynamo DB tables permission for stub table
./deploy-authdevs.sh --ticf-stub -p ( deploy the TICF CRI stub) verify the Dynamo DB tables permission for ticf stub table

Copy link

Java Tests Skipped

No Java files were changed in this pull request. Java tests will be skipped1.

Any Java files that are changed in a subsequent commit will trigger the Java tests.

Footnotes

  1. These tests will still show as passing in the PR status check, but will not actually have run.

@pskushwaha1 pskushwaha1 marked this pull request as ready for review April 24, 2025 15:27
@pskushwaha1 pskushwaha1 requested review from a team as code owners April 24, 2025 15:27
@ethanmills
Copy link
Contributor

Do we need kms perms in here too, or are they handled elsewhere?

@pskushwaha1 pskushwaha1 force-pushed the AUT-4213-update-dynamodb-table-policy branch from 7fecab0 to 3f5e4b4 Compare April 24, 2025 16:26
@pskushwaha1
Copy link
Contributor Author

Do we need kms perms in here too, or are they handled elsewhere?

I will raise another PR for KMS permission

monhaque
monhaque previously approved these changes Apr 25, 2025
@monhaque monhaque force-pushed the AUT-4213-update-dynamodb-table-policy branch from b9f265e to 42ebbec Compare May 7, 2025 15:13
@monhaque
Copy link
Contributor

monhaque commented May 8, 2025

Do we need kms perms in here too, or are they handled elsewhere?

I will raise another PR for KMS permission

#6407

@monhaque monhaque added this pull request to the merge queue May 8, 2025
Merged via the queue into main with commit 938c3c3 May 8, 2025
29 checks passed
@monhaque monhaque deleted the AUT-4213-update-dynamodb-table-policy branch May 8, 2025 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants