ATO-1565: remove orch setters #6265
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ryan-Andrews99
force-pushed
the
ATO-1565-remove-orch-setters
branch
3 times, most recently
from
aa78550 to
9c568de
Compare
Ryan-Andrews99
force-pushed
the
ATO-1565-remove-orch-setters
branch
2 times, most recently
from
76e4f86 to
da35f74
Compare
Ryan-Andrews99
commented
Apr 25, 2025
7 tasks
Removes the null-ing out of this value when the shared session is copied for max age handling.
This test was added as part of this commit: 037f9b2 which added behaviour for a mismatch in bsid cookie and the session value. The previous name was also inaccurate due to the fact that the request included bsid cookie. I think this test was supposed to test the mismatch, and with subequent changes has become a bit more inaccurate. This updates the tests to be a bit more specific to the mismatch case.
Ryan-Andrews99
force-pushed
the
ATO-1565-remove-orch-setters
branch
from
da35f74 to
103cd19
Compare
|
|
LGTM! |
|
Approved - but understanding look into some discrepancies between the shared and orch session for CCS. |
isaac-GDS
approved these changes
Apr 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wider context of change:
We previously migrated this field to the separate session stores for both Auth and Orch. However we continued to set the value in orchestration and left in logging which checked if the values were in sync. We've stopped reading the value in auth and we only get this in Orch in a few places:
Once we remove these we can stop setting in Authentication.
What’s changed:
Manual testing:
Checklist
Related PRs