Fix sync progress label to count skipped and errors - #60
Merged
Conversation
The "Processing X/N" label was only counting successfully imported images (processed), while the progress bar was driven by all handled images (processed + skipped + errors). For folders with mostly non-Fujifilm files, the bar would advance while the counter stayed at 0. Adds a handled field to SyncRunData and uses it in the label so it matches what the bar shows.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The "Processing X/N" label during library sync was only counting successfully
imported images (
processed), while the progress bar was driven by all handledimages (
processed + skipped + errors). For folders containing mostlyduplicates files the bar would advance while the counter stayed at 0/N throughout the sync.
Fix: adds a
handledfield toSyncRunData(already computed in the viewas
processed + skipped + errors) and uses it in thesync_status.htmltemplate label, making the counter consistent with the bar.