-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Signed-off-by: rfyiamcool <[email protected]>
- Loading branch information
1 parent
0cfb2ca
commit d293aa5
Showing
2 changed files
with
4 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d293aa5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why was this accepted?
messageType is an int with value websocket.BinaryMessage or websocket.TextMessage.
The websocket.FormatMessageType(mt) doesn't event exist in the latest release.
The messageType argument to the WriteMessage and NextWriter methods specifies the type of a sent message.
d293aa5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should have been merged only after the commit was released. @greenmarmot, are you planning to release a new version?
d293aa5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new version of the code doesn't have a FormatMessageType function and shouldn't be in the example, which can be confusing for beginners