Skip to content

Update AGP, NDK, CMake, and other dependencies #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

emrekultursay
Copy link

@emrekultursay emrekultursay commented Sep 24, 2024

This PR modernizes all samples to use relatively newer versions for most major dependencies. It uses the following versions:

AGP=7.4.2
Gradle=7.5
NDK=r25c
CMake=3.22.1
minSdkVersion=26
compileSdkVersion/targetSdkVersion=34
ABIs=arm64,x86_64 only
Validation Layers prebuilts=1.3.290.0

Also slightly bumps appcompat and game-activity dependency versions.

This change also updates all README files, and the test matrix used to verify all 6 tutorials.

Copy link

@spectecjr spectecjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So generally LGTM, but I'm not sure if we need x86_64 to have a different target SDK version (31) or not. Currently it's set to 34 in every sample, which the README says we need for other targets.

Assuming that what is in the CL is correct, this is good to go. Approving, assuming we can circle back if necessary.

Also fixes some minor things, and documents a known issue.
Copy link
Author

@emrekultursay emrekultursay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-did testing on API level 34 with x86_64 emulator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants