Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: release-please dependency upgrade #5652

Merged
merged 2 commits into from
Feb 7, 2025

Conversation

suztomo
Copy link
Member

@suztomo suztomo commented Feb 7, 2025

I removed packages/release-please/package-lock.json and ran "npm install" there. Now it got 10.2.0. Good.

suztomo@suztomo2:~/repo-automation-bots$ find . -name 'package-lock.json' |xargs grep jsonpath-plus
./packages/release-please/package-lock.json:    "node_modules/jsonpath-plus": {
./packages/release-please/package-lock.json:      "resolved": "https://registry.npmjs.org/jsonpath-plus/-/jsonpath-plus-10.2.0.tgz",

Then I observed error " Type 'Int32Array' is not generic." (see below). I upgraded the typescript version as per firebase/firebase-functions#1664.

@suztomo suztomo requested a review from a team as a code owner February 7, 2025 20:06
@suztomo
Copy link
Member Author

suztomo commented Feb 7, 2025

node_modules/@google-cloud/storage/build/cjs/src/crc32c.d.ts:6:39 - error TS2315: Type 'Int32Array' is not generic.

6 declare const CRC32C_EXTENSION_TABLE: Int32Array<ArrayBuffer>;
                                        ~~~~~~~~~~~~~~~~~~~~~~~

node_modules/@google-cloud/storage/build/cjs/src/crc32c.d.ts:1[15](https://github.com/googleapis/repo-automation-bots/actions/runs/13207210994/job/36873118479?pr=5652#step:8:16):45 - error TS2315: Type 'Int32Array' is not generic.

115     static readonly CRC32C_EXTENSION_TABLE: Int32Array<ArrayBuffer>;
                                                ~~~~~~~~~~~~~~~~~~~~~~~


Found 2 errors in the same file, starting at: node_modules/@google-cloud/storage/build/cjs/src/crc32c.d.ts:6

Maybe this firebase/firebase-functions#1664 ?

@suztomo suztomo merged commit 3a68a9c into googleapis:main Feb 7, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants