Skip to content

feat: LAR for dbapi #997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

feat: LAR for dbapi #997

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3c62fe4
change
asthamohta Aug 9, 2023
2595d7a
changes
asthamohta Aug 9, 2023
3df8ee6
changes
asthamohta Aug 9, 2023
b3d8dc1
changes
asthamohta Aug 9, 2023
ce40ff7
change
asthamohta Aug 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions google/cloud/spanner_dbapi/connection.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -508,7 +508,7 @@ def connect(
pool=None,
user_agent=None,
client=None,
route_to_leader_enabled=True,
route_to_leader_enabled=False,
):
"""Creates a connection to a Google Cloud Spanner database.

Expand Down Expand Up @@ -547,9 +547,11 @@ def connect(

:type route_to_leader_enabled: boolean
:param route_to_leader_enabled:
(Optional) Default True. Set route_to_leader_enabled as False to
(Optional) Default False. Set route_to_leader_enabled as False to
disable leader aware routing. Disabling leader aware routing would
route all requests in RW/PDML transactions to the closest region.
Inline Begin Transaction should be enabled to take advantage of the
the option.


:rtype: :class:`google.cloud.spanner_dbapi.connection.Connection`
Expand All @@ -567,14 +569,14 @@ def connect(
credentials,
project=project,
client_info=client_info,
route_to_leader_enabled=True,
route_to_leader_enabled=route_to_leader_enabled,
)
else:
client = spanner.Client(
project=project,
credentials=credentials,
client_info=client_info,
route_to_leader_enabled=True,
route_to_leader_enabled=route_to_leader_enabled,
)
else:
if project is not None and client.project != project:
Expand Down
4 changes: 2 additions & 2 deletions tests/unit/spanner_dbapi/test_connect.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ def test_w_explicit(self, mock_client):
project=PROJECT,
credentials=credentials,
client_info=mock.ANY,
route_to_leader_enabled=True,
route_to_leader_enabled=False,
)
client_info = mock_client.call_args_list[0][1]["client_info"]
self.assertEqual(client_info.user_agent, USER_AGENT)
Expand Down Expand Up @@ -120,7 +120,7 @@ def test_w_credential_file_path(self, mock_client):
credentials_path,
project=PROJECT,
client_info=mock.ANY,
route_to_leader_enabled=True,
route_to_leader_enabled=False,
)
client_info = factory.call_args_list[0][1]["client_info"]
self.assertEqual(client_info.user_agent, USER_AGENT)
Expand Down