Skip to content

feat(observability): enable OpenTelemetry metrics and tracing by default #1410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(observability): enable OpenTelemetry metrics and tracing by default #1410

wants to merge 1 commit into from

Conversation

sinhasubham
Copy link

This change enables OpenTelemetry metrics and tracing by default. [Fix for Issues 1222]

@product-auto-label product-auto-label bot added size: l Pull request size is large. api: spanner Issues related to the googleapis/python-spanner API. labels Sep 11, 2025
@sinhasubham sinhasubham marked this pull request as ready for review September 11, 2025 08:39
@sinhasubham sinhasubham requested review from a team as code owners September 11, 2025 08:39
@rahul2393
Copy link
Contributor

Overall looks good, some additional requests to include in this PR

  • Please fix the lint errors.
  • In other languages one can disable native metrics by setting env SPANNER_DISABLE_BUILTIN_METRICS to true, can we do same thing here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rahul2393 rahul2393 rahul2393 approved these changes

Assignees

@bhatt4982 bhatt4982

Labels
api: spanner Issues related to the googleapis/python-spanner API. size: l Pull request size is large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sinhasubham @rahul2393 @bhatt4982