Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(samples): catch EOFError in quickstart #708

Merged
merged 1 commit into from
Nov 17, 2023
Merged

fix(samples): catch EOFError in quickstart #708

merged 1 commit into from
Nov 17, 2023

Conversation

Linchin
Copy link
Contributor

@Linchin Linchin commented Nov 15, 2023 •
edited
Loading

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #707 🦕

@Linchin Linchin requested a review from shollyman November 15, 2023 19:22
@Linchin Linchin requested review from a team as code owners November 15, 2023 19:22
@Linchin Linchin requested a review from vchudnov-g November 15, 2023 19:22
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigquerystorage Issues related to the googleapis/python-bigquery-storage API. samples Issues that are directly related to samples. labels Nov 15, 2023
@Linchin Linchin requested review from chalmerlowe and removed request for vchudnov-g November 16, 2023 18:52
@Linchin Linchin merged commit 1683879 into googleapis:main Nov 17, 2023
13 checks passed
@release-please release-please bot mentioned this pull request Nov 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shollyman shollyman shollyman approved these changes

@chalmerlowe chalmerlowe Awaiting requested review from chalmerlowe

Assignees
No one assigned
Labels
api: bigquerystorage Issues related to the googleapis/python-bigquery-storage API. samples Issues that are directly related to samples. size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Samples continuous tests failing due to fastavro upgrade
2 participants
@Linchin @shollyman