Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add BigQueryWriteClient to module export #699

Closed
wants to merge 1 commit into from
Closed

fix: add BigQueryWriteClient to module export #699

wants to merge 1 commit into from

Conversation

Linchin
Copy link
Contributor

@Linchin Linchin commented Nov 6, 2023 •
edited
Loading

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #691 🦕

@Linchin Linchin requested review from a team as code owners November 6, 2023 19:52
@Linchin Linchin requested a review from obada-ab November 6, 2023 19:52
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: bigquerystorage Issues related to the googleapis/python-bigquery-storage API. labels Nov 6, 2023
@Linchin Linchin added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Nov 6, 2023
@Linchin
Copy link
Contributor Author

Linchin commented Nov 6, 2023

hold: Just realized that there's an existing PR for the same issue: #690

Will merge this one if the author doesn't respond in a long time.

@Linchin Linchin closed this Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m-strzelczyk m-strzelczyk m-strzelczyk approved these changes

@obada-ab obada-ab Awaiting requested review from obada-ab obada-ab is a code owner automatically assigned from googleapis/api-bigquery

Assignees
No one assigned
Labels
api: bigquerystorage Issues related to the googleapis/python-bigquery-storage API. do not merge Indicates a pull request not ready for merge, due to either quality or timing. size: xs Pull request size is extra small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BigQueryWriteClient export missing
2 participants
@Linchin @m-strzelczyk