Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support add, sub, mult, div, and more between timedeltas (#1396) #1396

Merged
merged 11 commits into from
Feb 19, 2025

Conversation

sycai
Copy link
Contributor

@sycai sycai commented Feb 13, 2025

BEGIN_COMMIT_OVERRIDE
feat: support add, sub, mult, div, and more between timedeltas (#1396)
END_COMMIT_OVERRIDE

Supported operators:

  • add
  • sub
  • mult
  • div
  • floordiv
  • abs
  • neg
  • pos

@product-auto-label product-auto-label bot added size: l Pull request size is large. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Feb 13, 2025
@sycai sycai changed the title chore: support operators within timedeltas chore: support operators between timedeltas Feb 14, 2025
@sycai sycai marked this pull request as ready for review February 14, 2025 20:58
@sycai sycai requested review from a team as code owners February 14, 2025 20:58
@sycai sycai requested a review from chelsea-lin February 14, 2025 20:58
@sycai sycai enabled auto-merge (squash) February 19, 2025 01:29
@sycai sycai merged commit ffa63d4 into main Feb 19, 2025
22 of 23 checks passed
@sycai sycai deleted the sycai_timedelta_internal_ops branch February 19, 2025 02:17
@tswast tswast changed the title chore: support operators between timedeltas feat: support operators between timedeltas Feb 19, 2025
@tswast tswast changed the title feat: support operators between timedeltas feat: support add, sub, mult, div, and more between timedeltas (#1396) Feb 19, 2025
@tswast
Copy link
Collaborator

tswast commented Feb 19, 2025

@sycai Why was this marked as a "chore: "? It is user-facing functionality and should appear in the changelog. I have added a commit message override for the release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: l Pull request size is large.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants