Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Add __init__.py to functions test modules #1371

Merged
merged 3 commits into from
Feb 6, 2025
Merged

chore: Add __init__.py to functions test modules #1371

merged 3 commits into from
Feb 6, 2025

Conversation

TrevorBergeron
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@TrevorBergeron TrevorBergeron requested review from a team as code owners February 6, 2025 07:03
@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Feb 6, 2025
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. label Feb 6, 2025
sycai
sycai approved these changes Feb 6, 2025
View reviewed changes
tests/system/large/functions/__init__.py
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we have the copy right header here too?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, added

@TrevorBergeron TrevorBergeron enabled auto-merge (squash) February 6, 2025 17:34
@TrevorBergeron TrevorBergeron merged commit 1970031 into main Feb 6, 2025
21 of 22 checks passed
@TrevorBergeron TrevorBergeron deleted the remote_test_conflicts branch February 6, 2025 19:26
shuoweil pushed a commit that referenced this pull request Feb 6, 2025
@TrevorBergeron
chore: Add __init__.py to functions test modules (#1371)
5e0fed8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sycai sycai sycai approved these changes

@jialuoo jialuoo jialuoo approved these changes

Assignees

@jialuoo jialuoo

Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TrevorBergeron @sycai @jialuoo