Skip to content

fix: updated span kind to CLIENT for ack and modack rpc spans #2029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

bizob2828
Copy link

@bizob2828 bizob2828 commented Apr 21, 2025

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #2028 🦕

This PR updates the span kind based on the unary pull example to set span kind to client for modack/ack spans. I also added some missing assertions from #2019

@bizob2828 bizob2828 requested review from a team as code owners April 21, 2025 21:05
Copy link

google-cla bot commented Apr 21, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@feywind
Copy link
Collaborator

feywind commented Apr 30, 2025

@bizob2828 Thanks for the PR! Let me run this by my OTel collaborator here.

@feywind feywind changed the title fix: Updated span kind to CLIENT for ack and modack rpc spans fix: updated span kind to CLIENT for ack and modack rpc spans May 8, 2025
@feywind
Copy link
Collaborator

feywind commented May 8, 2025

@bizob2828 Hey would you mind running npm run fix in your branch? We can't do that through a bot anymore :S

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsub Issues related to the googleapis/nodejs-pubsub API. size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

modack and ack spans are the incorrect span kind
2 participants