Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: [Google.Cloud.SecretManager.V1] updated comment for customer_managed_encryption in message .google.cloud.secretmanager.v1.Secret #14109

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

docs: [Google.Cloud.SecretManager.V1] updated comment for customer_managed_encryption in message .google.cloud.secretmanager.v1.Secret #14109

wants to merge 1 commit into from

Conversation

gcf-owl-bot[bot]
Copy link
Contributor

@gcf-owl-bot gcf-owl-bot bot commented Jan 16, 2025

  • Regenerate this pull request now.

docs: updated comment for scheduled_destroy_time in message .google.cloud.secretmanager.v1.SecretVersion
docs: updated comment for customer_managed_encryption in message .google.cloud.secretmanager.v1.SecretVersion
docs: updated comment for Replication
docs: updated comment for name in message .google.cloud.secretmanager.v1.Topic

PiperOrigin-RevId: 715945530

Source-Link: googleapis/googleapis@8c9639a

Source-Link: https://github.com/googleapis/googleapis-gen/commit/928e86adbcfead4bb3cce07b1a846b384ac90af6
Copy-Tag: eyJwIjoiYXBpcy9Hb29nbGUuQ2xvdWQuU2VjcmV0TWFuYWdlci5WMS8uT3dsQm90LnlhbWwiLCJoIjoiOTI4ZTg2YWRiY2ZlYWQ0YmIzY2NlMDdiMWE4NDZiMzg0YWM5MGFmNiJ9

@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Jan 16, 2025
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 16, 2025
@github-actions GitHub Actions
Copy link

Pull request diff results
OwlBot post-processor has not run: failing diff.

@gcf-owl-bot
docs: updated comment for customer_managed_encryption in message `.…
dd8849a 
…google.cloud.secretmanager.v1.Secret`

docs: updated comment for `scheduled_destroy_time` in message `.google.cloud.secretmanager.v1.SecretVersion`
docs: updated comment for `customer_managed_encryption` in message `.google.cloud.secretmanager.v1.SecretVersion`
docs: updated comment for `Replication`
docs: updated comment for `name` in message `.google.cloud.secretmanager.v1.Topic`

PiperOrigin-RevId: 715945530

Source-Link: googleapis/googleapis@8c9639a

Source-Link: googleapis/googleapis-gen@928e86a
Copy-Tag: eyJwIjoiYXBpcy9Hb29nbGUuQ2xvdWQuU2VjcmV0TWFuYWdlci5WMS8uT3dsQm90LnlhbWwiLCJoIjoiOTI4ZTg2YWRiY2ZlYWQ0YmIzY2NlMDdiMWE4NDZiMzg0YWM5MGFmNiJ9
@gcf-owl-bot gcf-owl-bot bot marked this pull request as ready for review January 16, 2025 01:18
@gcf-owl-bot gcf-owl-bot bot force-pushed the owl-bot-copy-apis-Google_Cloud_SecretManager_V1 branch from 6eab4e8 to dd8849a Compare January 16, 2025 01:18
@gcf-owl-bot gcf-owl-bot bot requested a review from a team as a code owner January 16, 2025 01:18
@trusted-contributions-gcf trusted-contributions-gcf bot added the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 16, 2025
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 16, 2025
@github-actions GitHub Actions
Copy link

Pull request diff results
Finding changes in Google.Cloud.SecretManager.V1...
Comparing old and new versions (by source)
Diff level: Identical

Comparing with previous NuGet package
Checking compatibility for Google.Cloud.SecretManager.V1 version 2.5.0
Differences from 2.5.0
Minor changes:
Dependency Google.Api.CommonProtos changed from v2.15.0.0 to v2.16.0.0
Dependency Google.Api.Gax changed from v4.8.0.0 to v4.9.0.0
Dependency Google.Api.Gax.Grpc changed from v4.8.0.0 to v4.9.0.0
Dependency Google.Protobuf changed from v3.25.0.0 to v3.28.2.0

Diff level: Minor

Finished comparisons for Google.Cloud.SecretManager.V1

@amanda-tarafa
Copy link
Contributor

amanda-tarafa commented Jan 16, 2025 •
edited
Loading

GitHub pull requests is degraded at the moment, so that might explain the "Problem generating the rebase commit". I'll taka a look later or tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amanda-tarafa amanda-tarafa amanda-tarafa approved these changes

Assignees
No one assigned
Labels
kokoro:force-run Add this label to force Kokoro to re-run the tests. owl-bot-copy
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@amanda-tarafa