Skip to content

Conversation

@olavloite
Copy link
Collaborator

No description provided.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @olavloite, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the dependency management for the spannerlib-dotnet-grpc-server within the SpannerLib .NET wrapper. It transitions from using a pre-built NuGet package to a direct project reference, facilitating a more integrated submodule approach. Concurrently, it standardizes the output directory for native runtime binaries, ensuring consistency across the build process and project configurations.

Highlights

  • Dependency Management: The spannerlib-dotnet-grpc-server component is now consumed as a direct project reference instead of a NuGet package, aligning with the integration of SpannerLib as a submodule.
  • Build Output Structure: Native runtime binaries for the GRPC server are now organized under a new runtimes/{platform}/native directory structure, replacing the previous binaries directory.
  • Build Script Updates: Build scripts (build-grpc-server.sh, build.sh) and project files (.csproj) have been updated to reflect the new runtime directory structure and dependency changes.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the build process for the .NET wrapper of SpannerLib. It changes the dependency on spannerlib-dotnet-grpc-server from a PackageReference to a ProjectReference, which means it's now built from source within the solution. The changes include updating build scripts, project files, and .gitignore to use a new runtimes directory for native binaries instead of binaries.

The changes are consistent and look correct. I've added one suggestion to improve the maintainability of a .csproj file by reducing duplication. Overall, this is a good improvement to the build process.

Comment on lines 18 to 24
<ItemGroup>
<None Include="binaries/any/*" Pack="true" PackagePath="runtimes/any/native/" />
<None Include="binaries/linux-x64/*" Pack="true" PackagePath="runtimes/linux-x64/native/" />
<None Include="binaries/linux-arm64/*" Pack="true" PackagePath="runtimes/linux-arm64/native/" />
<None Include="binaries/osx-arm64/*" Pack="true" PackagePath="runtimes/osx-arm64/native/" />
<None Include="binaries/win-x64/*" Pack="true" PackagePath="runtimes/win-x64/native/" />
<None Include="runtimes/any/native/*" Pack="true" PackagePath="runtimes/any/native/" CopyToOutputDirectory="PreserveNewest" />
<None Include="runtimes/linux-x64/native/*" Pack="true" PackagePath="runtimes/linux-x64/native/" CopyToOutputDirectory="PreserveNewest" />
<None Include="runtimes/linux-arm64/native/*" Pack="true" PackagePath="runtimes/linux-arm64/native/" CopyToOutputDirectory="PreserveNewest" />
<None Include="runtimes/osx-arm64/native/*" Pack="true" PackagePath="runtimes/osx-arm64/native/" CopyToOutputDirectory="PreserveNewest" />
<None Include="runtimes/win-x64/native/*" Pack="true" PackagePath="runtimes/win-x64/native/" CopyToOutputDirectory="PreserveNewest" />
</ItemGroup>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To improve maintainability and reduce repetition, you can define the list of runtimes as a separate item group and then use it to generate the <None> items. This makes it easier to add or remove runtimes in the future.

  <ItemGroup>
    <Runtimes Include="any" />
    <Runtimes Include="linux-x64" />
    <Runtimes Include="linux-arm64" />
    <Runtimes Include="osx-arm64" />
    <Runtimes Include="win-x64" />
    <None Include="runtimes/%(Runtimes.Identity)/native/*" Pack="true" PackagePath="runtimes/%(Runtimes.Identity)/native/" CopyToOutputDirectory="PreserveNewest" />
  </ItemGroup>

@olavloite olavloite closed this Jan 23, 2026
@olavloite olavloite deleted the spanner-lib-ado-net-submodule branch January 23, 2026 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant