-
Notifications
You must be signed in to change notification settings - Fork 31
chore: import SpannerLib in ado as submodule #737
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @olavloite, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refactors the dependency management for the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request refactors the build process for the .NET wrapper of SpannerLib. It changes the dependency on spannerlib-dotnet-grpc-server from a PackageReference to a ProjectReference, which means it's now built from source within the solution. The changes include updating build scripts, project files, and .gitignore to use a new runtimes directory for native binaries instead of binaries.
The changes are consistent and look correct. I've added one suggestion to improve the maintainability of a .csproj file by reducing duplication. Overall, this is a good improvement to the build process.
| <ItemGroup> | ||
| <None Include="binaries/any/*" Pack="true" PackagePath="runtimes/any/native/" /> | ||
| <None Include="binaries/linux-x64/*" Pack="true" PackagePath="runtimes/linux-x64/native/" /> | ||
| <None Include="binaries/linux-arm64/*" Pack="true" PackagePath="runtimes/linux-arm64/native/" /> | ||
| <None Include="binaries/osx-arm64/*" Pack="true" PackagePath="runtimes/osx-arm64/native/" /> | ||
| <None Include="binaries/win-x64/*" Pack="true" PackagePath="runtimes/win-x64/native/" /> | ||
| <None Include="runtimes/any/native/*" Pack="true" PackagePath="runtimes/any/native/" CopyToOutputDirectory="PreserveNewest" /> | ||
| <None Include="runtimes/linux-x64/native/*" Pack="true" PackagePath="runtimes/linux-x64/native/" CopyToOutputDirectory="PreserveNewest" /> | ||
| <None Include="runtimes/linux-arm64/native/*" Pack="true" PackagePath="runtimes/linux-arm64/native/" CopyToOutputDirectory="PreserveNewest" /> | ||
| <None Include="runtimes/osx-arm64/native/*" Pack="true" PackagePath="runtimes/osx-arm64/native/" CopyToOutputDirectory="PreserveNewest" /> | ||
| <None Include="runtimes/win-x64/native/*" Pack="true" PackagePath="runtimes/win-x64/native/" CopyToOutputDirectory="PreserveNewest" /> | ||
| </ItemGroup> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To improve maintainability and reduce repetition, you can define the list of runtimes as a separate item group and then use it to generate the <None> items. This makes it easier to add or remove runtimes in the future.
<ItemGroup>
<Runtimes Include="any" />
<Runtimes Include="linux-x64" />
<Runtimes Include="linux-arm64" />
<Runtimes Include="osx-arm64" />
<Runtimes Include="win-x64" />
<None Include="runtimes/%(Runtimes.Identity)/native/*" Pack="true" PackagePath="runtimes/%(Runtimes.Identity)/native/" CopyToOutputDirectory="PreserveNewest" />
</ItemGroup>
No description provided.