Skip to content

Conversation

@olavloite
Copy link
Collaborator

Adds support for using the .NET SpannerLib wrapper on linux-arm64.

@olavloite olavloite requested a review from a team as a code owner January 21, 2026 15:18
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @olavloite, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces support for the linux-arm64 architecture to the SpannerLib .NET gRPC wrapper. This enhancement enables the use of SpannerLib on systems with ARM64-based Linux distributions. The changes include modifications to the build scripts to compile the gRPC server for the new architecture, as well as updates to the .NET wrapper to correctly load the corresponding native binary.

Highlights

  • New Architecture Support: Adds support for the linux-arm64 architecture to the SpannerLib .NET gRPC wrapper.
  • Build Script Modification: The build scripts for both the gRPC server and the .NET wrapper have been updated to include the linux-arm64 architecture.
  • Code Update: The .NET server code has been updated to correctly identify and load the native binary for the linux-arm64 architecture.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds support for linux-arm64 to the SpannerLib .NET gRPC wrapper. The changes correctly add build steps for the new architecture in the shell scripts and update the C# code to locate the binary. However, I've identified a critical issue where the new binary is not included in the .NET project file, which would prevent it from being packaged and cause a runtime failure. Additionally, I've provided suggestions to refactor the build scripts to improve maintainability by reducing code duplication.

Adds support for using the .NET SpannerLib wrapper on linux-arm64.
@olavloite olavloite force-pushed the spannerlib-grpc-server-linux-arm64 branch from c8742e9 to 1203640 Compare January 21, 2026 15:56
@olavloite
Copy link
Collaborator Author

/gemini review

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request effectively adds support for linux-arm64 to the SpannerLib .NET gRPC wrapper. The changes are well-implemented across the build scripts, C# server logic, and project file. I particularly appreciate the refactoring of the shell scripts to use functions, which significantly improves maintainability and readability. I've provided a couple of minor suggestions to further refine the shell scripts for better robustness and idiomatic usage.

@olavloite olavloite requested a review from bhatt4982 January 21, 2026 16:22
Copy link
Contributor

@bhatt4982 bhatt4982 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM...

@olavloite olavloite merged commit 180e765 into main Jan 21, 2026
43 checks passed
@olavloite olavloite deleted the spannerlib-grpc-server-linux-arm64 branch January 21, 2026 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants