-
Notifications
You must be signed in to change notification settings - Fork 31
chore: support linux-arm64 for SpannerLib .NET gRPC #735
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @olavloite, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces support for the linux-arm64 architecture to the SpannerLib .NET gRPC wrapper. This enhancement enables the use of SpannerLib on systems with ARM64-based Linux distributions. The changes include modifications to the build scripts to compile the gRPC server for the new architecture, as well as updates to the .NET wrapper to correctly load the corresponding native binary. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds support for linux-arm64 to the SpannerLib .NET gRPC wrapper. The changes correctly add build steps for the new architecture in the shell scripts and update the C# code to locate the binary. However, I've identified a critical issue where the new binary is not included in the .NET project file, which would prevent it from being packaged and cause a runtime failure. Additionally, I've provided suggestions to refactor the build scripts to improve maintainability by reducing code duplication.
spannerlib/wrappers/spannerlib-dotnet/spannerlib-dotnet-grpc-server/Server.cs
Show resolved
Hide resolved
Adds support for using the .NET SpannerLib wrapper on linux-arm64.
c8742e9 to
1203640
Compare
|
/gemini review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request effectively adds support for linux-arm64 to the SpannerLib .NET gRPC wrapper. The changes are well-implemented across the build scripts, C# server logic, and project file. I particularly appreciate the refactoring of the shell scripts to use functions, which significantly improves maintainability and readability. I've provided a couple of minor suggestions to further refine the shell scripts for better robustness and idiomatic usage.
bhatt4982
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM...
Adds support for using the .NET SpannerLib wrapper on linux-arm64.