Skip to content

Conversation

@olavloite
Copy link
Collaborator

The value of the DecodeToNativeArrays option in ConnectorConfig should be copied to the initial connection state.

Fixes #731

The value of the DecodeToNativeArrays option in ConnectorConfig should
be copied to the initial connection state.

Fixes #731
@olavloite olavloite requested a review from a team as a code owner January 21, 2026 14:34
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @olavloite, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical bug where the DecodeToNativeArrays setting, when provided via the ConnectorConfig, was not being properly propagated to the underlying database connection. This fix ensures that connections correctly honor this configuration, improving data type handling. Additionally, the changes include an updated test suite to validate the correct application of this setting, enhancing the robustness of the driver.

Highlights

  • Bug Fix: DecodeToNativeArrays: The DecodeToNativeArrays option specified in ConnectorConfig is now correctly copied to the initial connection state, resolving an issue where this setting was previously ignored.
  • Test Coverage: An existing test case (TestQueryWithAllNativeTypes) has been enhanced to explicitly verify that DecodeToNativeArrays is correctly applied when configured through ConnectorConfig, alongside the existing parameter-based configuration.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly fixes an issue where the DecodeToNativeArrays option in ConnectorConfig was being ignored. The change in driver.go ensures this option is properly copied to the initial connection state, consistent with other connector configuration properties. The accompanying update to driver_with_mockserver_test.go is excellent, refactoring the test to cover both setting the option via ConnectorConfig and through connection string parameters. This ensures the fix is robust and well-tested. The changes are clean, correct, and improve the driver's reliability.

Copy link
Contributor

@bhatt4982 bhatt4982 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM...

@olavloite olavloite merged commit 97a84c7 into main Jan 21, 2026
43 checks passed
@olavloite olavloite deleted the issue-731 branch January 21, 2026 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DecodeToNativeArrays connector config not respected anymore

2 participants