-
Notifications
You must be signed in to change notification settings - Fork 31
chore: .net publish script #732
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @olavloite, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the .NET publishing process by integrating SourceLink across all projects, which will greatly improve the debugging experience for developers using these packages. It also standardizes continuous integration build properties and package metadata, ensuring more consistent and traceable releases. The publishing script has been updated to include an explicit build step, preventing potential issues during package creation. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the .NET project files to include properties for NuGet publishing, such as SourceLink integration, and modifies the publish script. The changes are generally good, but I've identified a few areas with redundant configuration and commands that could be simplified for better maintainability. My comments suggest removing a redundant dotnet build command from the publish.sh script and removing duplicated property settings in the .csproj files.
| # Remove existing packages to ensure that only the packages that are built in the next step will be pushed to nuget. | ||
| find ./**/bin/Release -type f -name "Alpha*.nupkg" -exec rm {} \; | ||
|
|
||
| dotnet build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| <PropertyGroup Condition="'$(GITHUB_ACTIONS)' == 'true'"> | ||
| <ContinuousIntegrationBuild>true</ContinuousIntegrationBuild> | ||
| </PropertyGroup> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| <PackageId>Alpha.Google.Cloud.SpannerLib</PackageId> | ||
| <Version>1.0.0-alpha.20260119112406</Version> | ||
| <Version>1.0.0-alpha.20260120171501</Version> | ||
| <PackageVersion>$(Version)</PackageVersion> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
429b0ed to
0d35805
Compare
No description provided.