Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/integration-tests-on-emulator.yml
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ jobs:
- name: Set up Ruby
uses: ruby/setup-ruby@v1
with:
ruby-version: '3.4.7'
ruby-version: '4.0.1'
working-directory: spannerlib/wrappers/spannerlib-ruby
bundler-cache: true
- name: Compile and Run Ruby Integration Tests
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/release-ruby-wrapper.yml
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ jobs:
- name: Set up Ruby
uses: ruby/setup-ruby@v1
with:
ruby-version: '3.4.7'
ruby-version: '4.0.1'
bundler-cache: true
working-directory: 'spannerlib/wrappers/spannerlib-ruby'

Expand Down Expand Up @@ -95,7 +95,7 @@ jobs:
- name: Set up Ruby
uses: ruby/setup-ruby@v1
with:
ruby-version: '3.4.7'
ruby-version: '4.0.1'
bundler-cache: true
working-directory: 'spannerlib/wrappers/spannerlib-ruby'

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/ruby-wrapper-lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ jobs:
- name: Set up Ruby
uses: ruby/setup-ruby@v1
with:
ruby-version: '3.4.7'
ruby-version: '4.0.1'
bundler-cache: true
working-directory: spannerlib/wrappers/spannerlib-ruby

Expand Down
2 changes: 1 addition & 1 deletion spannerlib/wrappers/spannerlib-ruby/Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ gemspec
gem "rake", "~> 13.0"

group :development, :test do
gem "minitest", "~> 5.0"
gem "minitest", "~> 6.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

This major version upgrade to minitest v6 introduces significant breaking changes that will likely break your test suite. According to the official release notes, some of the breaking changes include:

  • Dropped support for Ruby versions below 3.0.
  • Minitest::Unit::TestCase has been removed (use Minitest::Test).
  • assert_nothing_raised has been removed (use assert_silent).
  • assert_raises now requires an exception class to be specified.

Before merging, please ensure that the entire test suite is executed and passes. If minitest is not actively used, it would be better to remove this dependency rather than update it.

gem "rake-compiler", "~> 1.0"
gem "rspec", "~> 3.0"
gem "rubocop", require: false
Expand Down