Skip to content

change from deprecated ...set_option to set_options #804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

change from deprecated ...set_option to set_options #804

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f0a7bba
change from deprecated ...set_option to set_options
Spirit-act Apr 23, 2025
220a5a5
add missing nullable typehint
Spirit-act Apr 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Google/AdsApi/AdManager/AdManagerServices.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,8 @@ final class AdManagerServices implements AdsServices
* @param AdManagerHeaderHandler|null $adManagerHeaderHandler
*/
public function __construct(
AdsSoapClientFactory $adsSoapClientFactory = null,
AdManagerHeaderHandler $adManagerHeaderHandler = null
?AdsSoapClientFactory $adsSoapClientFactory = null,
?AdManagerHeaderHandler $adManagerHeaderHandler = null
) {
$this->adsSoapClientFactory = ($adsSoapClientFactory === null)
? new AdsSoapClientFactory(
Expand Down
2 changes: 1 addition & 1 deletion src/Google/AdsApi/AdManager/AdManagerSessionBuilder.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ public function __construct()
* @throws InvalidArgumentException if the configuration file could not be
* found
*/
public function fromFile(string $path = null)
public function fromFile(?string $path = null)
{
if ($path === null) {
$path = self::DEFAULT_CONFIGURATION_FILENAME;
Expand Down
10 changes: 5 additions & 5 deletions src/Google/AdsApi/AdManager/v202405/AvailabilityForecast.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ class AvailabilityForecast
* @param \Google\AdsApi\AdManager\v202405\ContendingLineItem[] $contendingLineItems
* @param \Google\AdsApi\AdManager\v202405\AlternativeUnitTypeForecast[] $alternativeUnitTypeForecasts
*/
public function __construct($lineItemId = null, $orderId = null, $unitType = null, $availableUnits = null, $deliveredUnits = null, $matchedUnits = null, $possibleUnits = null, $reservedUnits = null, array $breakdowns = null, array $targetingCriteriaBreakdowns = null, array $contendingLineItems = null, array $alternativeUnitTypeForecasts = null)
public function __construct($lineItemId = null, $orderId = null, $unitType = null, $availableUnits = null, $deliveredUnits = null, $matchedUnits = null, $possibleUnits = null, $reservedUnits = null, ?array $breakdowns = null, ?array $targetingCriteriaBreakdowns = null, ?array $contendingLineItems = null, ?array $alternativeUnitTypeForecasts = null)
{
$this->lineItemId = $lineItemId;
$this->orderId = $orderId;
Expand Down Expand Up @@ -262,7 +262,7 @@ public function getBreakdowns()
* @param \Google\AdsApi\AdManager\v202405\ForecastBreakdown[]|null $breakdowns
* @return \Google\AdsApi\AdManager\v202405\AvailabilityForecast
*/
public function setBreakdowns(array $breakdowns = null)
public function setBreakdowns(?array $breakdowns = null)
{
$this->breakdowns = $breakdowns;
return $this;
Expand All @@ -280,7 +280,7 @@ public function getTargetingCriteriaBreakdowns()
* @param \Google\AdsApi\AdManager\v202405\TargetingCriteriaBreakdown[]|null $targetingCriteriaBreakdowns
* @return \Google\AdsApi\AdManager\v202405\AvailabilityForecast
*/
public function setTargetingCriteriaBreakdowns(array $targetingCriteriaBreakdowns = null)
public function setTargetingCriteriaBreakdowns(?array $targetingCriteriaBreakdowns = null)
{
$this->targetingCriteriaBreakdowns = $targetingCriteriaBreakdowns;
return $this;
Expand All @@ -298,7 +298,7 @@ public function getContendingLineItems()
* @param \Google\AdsApi\AdManager\v202405\ContendingLineItem[]|null $contendingLineItems
* @return \Google\AdsApi\AdManager\v202405\AvailabilityForecast
*/
public function setContendingLineItems(array $contendingLineItems = null)
public function setContendingLineItems(?array $contendingLineItems = null)
{
$this->contendingLineItems = $contendingLineItems;
return $this;
Expand All @@ -316,7 +316,7 @@ public function getAlternativeUnitTypeForecasts()
* @param \Google\AdsApi\AdManager\v202405\AlternativeUnitTypeForecast[]|null $alternativeUnitTypeForecasts
* @return \Google\AdsApi\AdManager\v202405\AvailabilityForecast
*/
public function setAlternativeUnitTypeForecasts(array $alternativeUnitTypeForecasts = null)
public function setAlternativeUnitTypeForecasts(?array $alternativeUnitTypeForecasts = null)
{
$this->alternativeUnitTypeForecasts = $alternativeUnitTypeForecasts;
return $this;
Expand Down
8 changes: 4 additions & 4 deletions src/Google/AdsApi/AdManager/v202405/CreativePlaceholder.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ class CreativePlaceholder
* @param string $targetingName
* @param boolean $isAmpOnly
*/
public function __construct($size = null, $creativeTemplateId = null, array $companions = null, array $appliedLabels = null, array $effectiveAppliedLabels = null, $expectedCreativeCount = null, $creativeSizeType = null, $targetingName = null, $isAmpOnly = null)
public function __construct($size = null, $creativeTemplateId = null, ?array $companions = null, ?array $appliedLabels = null, ?array $effectiveAppliedLabels = null, $expectedCreativeCount = null, $creativeSizeType = null, $targetingName = null, $isAmpOnly = null)
{
$this->size = $size;
$this->creativeTemplateId = $creativeTemplateId;
Expand Down Expand Up @@ -127,7 +127,7 @@ public function getCompanions()
* @param \Google\AdsApi\AdManager\v202405\CreativePlaceholder[]|null $companions
* @return \Google\AdsApi\AdManager\v202405\CreativePlaceholder
*/
public function setCompanions(array $companions = null)
public function setCompanions(?array $companions = null)
{
$this->companions = $companions;
return $this;
Expand All @@ -145,7 +145,7 @@ public function getAppliedLabels()
* @param \Google\AdsApi\AdManager\v202405\AppliedLabel[]|null $appliedLabels
* @return \Google\AdsApi\AdManager\v202405\CreativePlaceholder
*/
public function setAppliedLabels(array $appliedLabels = null)
public function setAppliedLabels(?array $appliedLabels = null)
{
$this->appliedLabels = $appliedLabels;
return $this;
Expand All @@ -163,7 +163,7 @@ public function getEffectiveAppliedLabels()
* @param \Google\AdsApi\AdManager\v202405\AppliedLabel[]|null $effectiveAppliedLabels
* @return \Google\AdsApi\AdManager\v202405\CreativePlaceholder
*/
public function setEffectiveAppliedLabels(array $effectiveAppliedLabels = null)
public function setEffectiveAppliedLabels(?array $effectiveAppliedLabels = null)
{
$this->effectiveAppliedLabels = $effectiveAppliedLabels;
return $this;
Expand Down
8 changes: 4 additions & 4 deletions src/Google/AdsApi/AdManager/v202405/InventoryTargeting.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ class InventoryTargeting
* @param \Google\AdsApi\AdManager\v202405\AdUnitTargeting[] $excludedAdUnits
* @param int[] $targetedPlacementIds
*/
public function __construct(array $targetedAdUnits = null, array $excludedAdUnits = null, array $targetedPlacementIds = null)
public function __construct(?array $targetedAdUnits = null, ?array $excludedAdUnits = null, ?array $targetedPlacementIds = null)
{
$this->targetedAdUnits = $targetedAdUnits;
$this->excludedAdUnits = $excludedAdUnits;
Expand All @@ -48,7 +48,7 @@ public function getTargetedAdUnits()
* @param \Google\AdsApi\AdManager\v202405\AdUnitTargeting[]|null $targetedAdUnits
* @return \Google\AdsApi\AdManager\v202405\InventoryTargeting
*/
public function setTargetedAdUnits(array $targetedAdUnits = null)
public function setTargetedAdUnits(?array $targetedAdUnits = null)
{
$this->targetedAdUnits = $targetedAdUnits;
return $this;
Expand All @@ -66,7 +66,7 @@ public function getExcludedAdUnits()
* @param \Google\AdsApi\AdManager\v202405\AdUnitTargeting[]|null $excludedAdUnits
* @return \Google\AdsApi\AdManager\v202405\InventoryTargeting
*/
public function setExcludedAdUnits(array $excludedAdUnits = null)
public function setExcludedAdUnits(?array $excludedAdUnits = null)
{
$this->excludedAdUnits = $excludedAdUnits;
return $this;
Expand All @@ -84,7 +84,7 @@ public function getTargetedPlacementIds()
* @param int[]|null $targetedPlacementIds
* @return \Google\AdsApi\AdManager\v202405\InventoryTargeting
*/
public function setTargetedPlacementIds(array $targetedPlacementIds = null)
public function setTargetedPlacementIds(?array $targetedPlacementIds = null)
{
$this->targetedPlacementIds = $targetedPlacementIds;
return $this;
Expand Down
4 changes: 2 additions & 2 deletions src/Google/AdsApi/AdManager/v202405/LineItem.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ class LineItem extends \Google\AdsApi\AdManager\v202405\LineItemSummary
* @param \Google\AdsApi\AdManager\v202405\Targeting $targeting
* @param \Google\AdsApi\AdManager\v202405\CreativeTargeting[] $creativeTargetings
*/
public function __construct($orderId = null, $id = null, $name = null, $externalId = null, $orderName = null, $startDateTime = null, $startDateTimeType = null, $endDateTime = null, $autoExtensionDays = null, $unlimitedEndDateTime = null, $creativeRotationType = null, $deliveryRateType = null, $deliveryForecastSource = null, $customPacingCurve = null, $roadblockingType = null, $skippableAdType = null, array $frequencyCaps = null, $lineItemType = null, $priority = null, $costPerUnit = null, $valueCostPerUnit = null, $costType = null, $discountType = null, $discount = null, $contractedUnitsBought = null, array $creativePlaceholders = null, array $activityAssociations = null, $environmentType = null, array $allowedFormats = null, $companionDeliveryOption = null, $allowOverbook = null, $skipInventoryCheck = null, $skipCrossSellingRuleWarningChecks = null, $reserveAtCreation = null, $stats = null, $deliveryIndicator = null, $deliveryData = null, $budget = null, $status = null, $reservationStatus = null, $isArchived = null, $webPropertyCode = null, array $appliedLabels = null, array $effectiveAppliedLabels = null, $disableSameAdvertiserCompetitiveExclusion = null, $lastModifiedByApp = null, $notes = null, $competitiveConstraintScope = null, $lastModifiedDateTime = null, $creationDateTime = null, array $customFieldValues = null, $isMissingCreatives = null, $programmaticCreativeSource = null, $thirdPartyMeasurementSettings = null, $youtubeKidsRestricted = null, $videoMaxDuration = null, $primaryGoal = null, array $secondaryGoals = null, $grpSettings = null, $dealInfo = null, array $viewabilityProviderCompanyIds = null, $childContentEligibility = null, $customVastExtension = null, $targeting = null, array $creativeTargetings = null)
public function __construct($orderId = null, $id = null, $name = null, $externalId = null, $orderName = null, $startDateTime = null, $startDateTimeType = null, $endDateTime = null, $autoExtensionDays = null, $unlimitedEndDateTime = null, $creativeRotationType = null, $deliveryRateType = null, $deliveryForecastSource = null, $customPacingCurve = null, $roadblockingType = null, $skippableAdType = null, ?array $frequencyCaps = null, $lineItemType = null, $priority = null, $costPerUnit = null, $valueCostPerUnit = null, $costType = null, $discountType = null, $discount = null, $contractedUnitsBought = null, ?array $creativePlaceholders = null, ?array $activityAssociations = null, $environmentType = null, ?array $allowedFormats = null, $companionDeliveryOption = null, $allowOverbook = null, $skipInventoryCheck = null, $skipCrossSellingRuleWarningChecks = null, $reserveAtCreation = null, $stats = null, $deliveryIndicator = null, $deliveryData = null, $budget = null, $status = null, $reservationStatus = null, $isArchived = null, $webPropertyCode = null, ?array $appliedLabels = null, ?array $effectiveAppliedLabels = null, $disableSameAdvertiserCompetitiveExclusion = null, $lastModifiedByApp = null, $notes = null, $competitiveConstraintScope = null, $lastModifiedDateTime = null, $creationDateTime = null, ?array $customFieldValues = null, $isMissingCreatives = null, $programmaticCreativeSource = null, $thirdPartyMeasurementSettings = null, $youtubeKidsRestricted = null, $videoMaxDuration = null, $primaryGoal = null, ?array $secondaryGoals = null, $grpSettings = null, $dealInfo = null, ?array $viewabilityProviderCompanyIds = null, $childContentEligibility = null, $customVastExtension = null, $targeting = null, ?array $creativeTargetings = null)
{
parent::__construct($orderId, $id, $name, $externalId, $orderName, $startDateTime, $startDateTimeType, $endDateTime, $autoExtensionDays, $unlimitedEndDateTime, $creativeRotationType, $deliveryRateType, $deliveryForecastSource, $customPacingCurve, $roadblockingType, $skippableAdType, $frequencyCaps, $lineItemType, $priority, $costPerUnit, $valueCostPerUnit, $costType, $discountType, $discount, $contractedUnitsBought, $creativePlaceholders, $activityAssociations, $environmentType, $allowedFormats, $companionDeliveryOption, $allowOverbook, $skipInventoryCheck, $skipCrossSellingRuleWarningChecks, $reserveAtCreation, $stats, $deliveryIndicator, $deliveryData, $budget, $status, $reservationStatus, $isArchived, $webPropertyCode, $appliedLabels, $effectiveAppliedLabels, $disableSameAdvertiserCompetitiveExclusion, $lastModifiedByApp, $notes, $competitiveConstraintScope, $lastModifiedDateTime, $creationDateTime, $customFieldValues, $isMissingCreatives, $programmaticCreativeSource, $thirdPartyMeasurementSettings, $youtubeKidsRestricted, $videoMaxDuration, $primaryGoal, $secondaryGoals, $grpSettings, $dealInfo, $viewabilityProviderCompanyIds, $childContentEligibility, $customVastExtension);
$this->targeting = $targeting;
Expand Down Expand Up @@ -123,7 +123,7 @@ public function getCreativeTargetings()
* @param \Google\AdsApi\AdManager\v202405\CreativeTargeting[]|null $creativeTargetings
* @return \Google\AdsApi\AdManager\v202405\LineItem
*/
public function setCreativeTargetings(array $creativeTargetings = null)
public function setCreativeTargetings(?array $creativeTargetings = null)
{
$this->creativeTargetings = $creativeTargetings;
return $this;
Expand Down
Loading